Merge lp:~osomon/webbrowser-app/session-restore-tab-load into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1457
Merged at revision: 1462
Proposed branch: lp:~osomon/webbrowser-app/session-restore-tab-load
Merge into: lp:webbrowser-app
Diff against target: 51 lines (+12/-4)
1 file modified
src/app/webbrowser/Browser.qml (+12/-4)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/session-restore-tab-load
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+295177@code.launchpad.net

Commit message

Only load the current tab when the session is restored.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2016-05-09 15:16:46 +0000
3+++ src/app/webbrowser/Browser.qml 2016-05-19 09:02:09 +0000
4@@ -1675,7 +1675,13 @@
5 store(JSON.stringify({tabs: tabs, currentIndex: publicTabsModel.currentIndex}))
6 }
7
8+ property bool restoring: false
9 function restore() {
10+ restoring = true
11+ _doRestore()
12+ restoring = false
13+ }
14+ function _doRestore() {
15 if (!locked) {
16 return
17 }
18@@ -1690,11 +1696,11 @@
19 if (tabs) {
20 for (var i = 0; i < Math.min(tabs.length, browser.maxTabsToRestore); ++i) {
21 var tab = createTabFromState(tabs[i])
22- internal.addTab(tab, i == 0)
23+ internal.addTab(tab, false)
24 }
25 }
26 if ('currentIndex' in state) {
27- internal.switchToTab(state.currentIndex, true)
28+ internal.switchToTab(state.currentIndex, false)
29 }
30 }
31 }
32@@ -1814,7 +1820,9 @@
33 if (tabsModel.count == 0) {
34 browser.openUrlInNewTab(settings.homepage, true, false)
35 }
36- tabsModel.currentTab.load()
37+ if (!delayedTabSwitcher.running) {
38+ tabsModel.currentTab.load()
39+ }
40 if (!tabsModel.currentTab.url.toString() && !tabsModel.currentTab.restoreState) {
41 internal.maybeFocusAddressBar()
42 }
43@@ -1876,7 +1884,7 @@
44 }
45
46 Connections {
47- target: tabsModel
48+ target: session.restoring ? null : tabsModel
49 onCurrentIndexChanged: {
50 // In narrow mode, the tabslist is a stack:
51 // the current tab is always at the top.

Subscribers

People subscribed via source and target branches

to status/vote changes: