Merge lp:~osomon/webbrowser-app/search-engines-overlap-header into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1012
Merged at revision: 1020
Proposed branch: lp:~osomon/webbrowser-app/search-engines-overlap-header
Merge into: lp:webbrowser-app
Diff against target: 10 lines (+1/-0)
1 file modified
src/app/webbrowser/SettingsPage.qml (+1/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/search-engines-overlap-header
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Riccardo Padovani (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+259211@code.launchpad.net

Commit message

Ensure the search engine delegates do not overlap with the settings header.

To post a comment you must log in.
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Looks good to me, works as expected. Thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/SettingsPage.qml'
2--- src/app/webbrowser/SettingsPage.qml 2015-04-22 10:25:56 +0000
3+++ src/app/webbrowser/SettingsPage.qml 2015-05-15 09:06:10 +0000
4@@ -182,6 +182,7 @@
5 right: parent.right
6 bottom: parent.bottom
7 }
8+ clip: true
9
10 model: searchEngineFolder
11

Subscribers

People subscribed via source and target branches

to status/vote changes: