Merge lp:~osomon/webbrowser-app/remove-tab-visibility-workaround into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 615
Merged at revision: 615
Proposed branch: lp:~osomon/webbrowser-app/remove-tab-visibility-workaround
Merge into: lp:webbrowser-app
Diff against target: 20 lines (+0/-10)
1 file modified
src/app/webbrowser/Browser.qml (+0/-10)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/remove-tab-visibility-workaround
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+226069@code.launchpad.net

Commit message

Remove a workaround for bug #1322622 that has been properly fixed in oxide.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2014-07-08 08:22:55 +0000
3+++ src/app/webbrowser/Browser.qml 2014-07-09 07:28:12 +0000
4@@ -273,16 +273,6 @@
5 }
6 }
7
8- // Work around http://pad.lv/1322622 by forcing an update
9- // of the visibility of the webview.
10- readonly property bool empty: !url.toString()
11- onEmptyChanged: {
12- if (!empty) {
13- visible = false
14- visible = Qt.binding(function() { return current })
15- }
16- }
17-
18 Loader {
19 id: newTabViewLoader
20 anchors.fill: parent

Subscribers

People subscribed via source and target branches

to status/vote changes: