Merge lp:~osomon/webbrowser-app/qt-labs-settings into lp:webbrowser-app
| Status: | Merged |
|---|---|
| Approved by: | Olivier Tilloy on 2015-04-01 |
| Approved revision: | 940 |
| Merged at revision: | 956 |
| Proposed branch: | lp:~osomon/webbrowser-app/qt-labs-settings |
| Merge into: | lp:webbrowser-app |
| Prerequisite: | lp:~osomon/webbrowser-app/searchengine-qml |
| Diff against target: |
357 lines (+49/-134) 10 files modified
README (+9/-2) debian/control (+1/-0) src/app/browserapplication.cpp (+1/-0) src/app/config.h.in (+1/-3) src/app/webbrowser/Browser.qml (+34/-12) src/app/webbrowser/CMakeLists.txt (+0/-1) src/app/webbrowser/settings.cpp (+0/-54) src/app/webbrowser/settings.h (+0/-49) src/app/webbrowser/webbrowser-app.cpp (+1/-7) src/app/webbrowser/webbrowser-app.qml (+2/-6) |
| To merge this branch: | bzr merge lp:~osomon/webbrowser-app/qt-labs-settings |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-03-27 | |
| Riccardo Padovani (community) | Approve on 2015-03-24 | ||
| Ubuntu Phablet Team | 2015-03-23 | Pending | |
|
Review via email:
|
|||
Commit Message
Use Qt.labs.settings to read/write the browser settings. This adds qml-module-
- 937. By Olivier Tilloy on 2015-03-23
-
Merge the latest changes from trunk and resolve a conflict.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:937
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:937
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 938. By Olivier Tilloy on 2015-03-24
-
Add a restoreDefaults() method to the settings object.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:938
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:938
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 939. By Olivier Tilloy on 2015-03-27
-
Merge the latest changes from trunk and resolve a conflict.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:939
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 940. By Olivier Tilloy on 2015-03-27
-
Remove top-level properties for settings.
Instead, properties should be set on the Settings instance directly, and the Settings instance is meant to be shared between views.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:940
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:940
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

FAILED: Continuous integration, rev:937 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 1554/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1932/console jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- amd64-ci/ 312 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 312 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 312/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- i386-ci/ 312 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1702/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1930 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1930/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 19086
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/webbrowser- app-ci/ 1554/rebuild
http://