Merge lp:~osomon/webbrowser-app/preview-grid-fixes into lp:webbrowser-app
Proposed by
Olivier Tilloy
Status: | Merged |
---|---|
Approved by: | Olivier Tilloy |
Approved revision: | 1239 |
Merged at revision: | 1240 |
Proposed branch: | lp:~osomon/webbrowser-app/preview-grid-fixes |
Merge into: | lp:webbrowser-app |
Diff against target: |
66 lines (+13/-2) 3 files modified
src/app/webbrowser/NewTabView.qml (+3/-0) src/app/webbrowser/UrlPreviewDelegate.qml (+9/-2) src/app/webbrowser/UrlPreviewGrid.qml (+1/-0) |
To merge this branch: | bzr merge lp:~osomon/webbrowser-app/preview-grid-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Ubuntu Phablet Team | Pending | ||
Review via email: mp+274673@code.launchpad.net |
Commit message
Fixes for minor UX issues with the preview grid:
- Make the highlight follow the item selected for deletion in the preview grid.
- Do not show a highlight in the narrow version of the new tab view, as it doesn’t support keyboard navigation.
- Grab dismiss area events so that they are not propagated to the view below when dismissing a context menu.
To post a comment you must log in.
FAILED: Continuous integration, rev:1239 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 2362/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 4673 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- amd64-ci/ 1116/console jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 1116 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 1116/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- i386-ci/ 1116 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 3771 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 4670 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 4670/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 24280
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/webbrowser- app-ci/ 2362/rebuild
http://