webbrowser-app

Merge lp:~osomon/webbrowser-app/multiple-qquickwindows into lp:webbrowser-app

  1. multiple-qquickwindows
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 400
Merged at revision: 401
Proposed branch: lp:~osomon/webbrowser-app/multiple-qquickwindows
Merge into: lp:webbrowser-app
Diff against target: 16 lines (+7/-1)
1 file modified
tests/autopilot/webbrowser_app/tests/test_title.py (+7/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/multiple-qquickwindows
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Chris Gagnon (community) Approve
Review via email: mp+194129@code.launchpad.net

Commit message

Fix a test failing with autopilot 1.4.
This is likely a bug in autopilot (or its Qt layer) itself, needs more investigation.
In the meantime, this fix should be safe.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:400
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/520/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/519
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/507/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/22/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/479
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/519
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/519/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/507
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/507/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3158/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1138

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/webbrowser-app-ci/520/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:400
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/521/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/524
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/512
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/23/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/483
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/524
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/524/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/512
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/512/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3163
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1143

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/webbrowser-app-ci/521/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

LGTM approved

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/webbrowser-app-autolanding/327/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/529
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/517/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-autolanding/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/7
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/7/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-autolanding/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/488
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/529
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/529/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/517/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/webbrowser-app-autolanding/328/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/530
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/518/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-autolanding/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/8
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/8/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-autolanding/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/489
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/530
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/530/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/518
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/518/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2986/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3168
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1150
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1149

review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

The phone failed to be provisioned re-approved

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/webbrowser-app-autolanding/329/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/536
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/524/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-autolanding/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/9
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-autolanding/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/494
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/536
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/536/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/524
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/524/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2991/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3173
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1160
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1159

review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

Failed on the phone becuase:

webbrowser-app-autopilot : Depends: libautopilot-qt (>= 1.4) but 1.3+13.10.20130814-0ubuntu1 is to be installed
E: Unable to correct problems, you have held broken packages.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/webbrowser-app-autolanding/330/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/545/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/533/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-autolanding/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/10
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/10/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-autolanding/10
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/502/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/545
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/545/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/533
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/533/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/3000/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3182/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1184
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1183

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/webbrowser_app/tests/test_title.py'
2--- tests/autopilot/webbrowser_app/tests/test_title.py 2013-08-29 16:28:44 +0000
3+++ tests/autopilot/webbrowser_app/tests/test_title.py 2013-11-06 12:44:59 +0000
4@@ -23,5 +23,11 @@
5 body = "<p>Lorem ipsum dolor sit amet.</p>"
6 url = self.make_html_page(title, body)
7 self.go_to_url(url)
8- window = self.app.select_single("QQuickWindow")
9+ #window = self.app.select_single("QQuickWindow")
10+ # XXX: for some reason, autopilot finds two instances of QQuickWindow.
11+ # One is the correct one, and the other one is not visible, its
12+ # dimensions are 0×0, it has no title, its parent is the webbrowser-app
13+ # object, and it has no children.
14+ windows = self.app.select_many("QQuickWindow")
15+ window = [w for w in windows if w.visible][0]
16 self.assertThat(window.title, Eventually(Contains(title)))

Subscribers

People subscribed via source and target branches

to status/vote changes: