Merge lp:~osomon/webbrowser-app/mir-libs into lp:webbrowser-app/staging

[Olivier Tilloy]

Add mir-libs content plug.

[Michael Terry (mterry)]

+ - mir-libs

I don't believe you need this line? But I'm not an expert and even if you don't need it, I think it's harmless, so fine.

(the global plug list applies its plugs to all your commands already)

+ default-provider: mir-libs:mir-libs

It's hard to say because this line isn't used by snapd at all yet, but I think you just need "mir-libs" here. c.f. the ubuntu-app-platform stanza below this one.

[lp:~osomon/webbrowser-app/mir-libs]

1640. By Olivier Tilloy on 2017-03-28

Non-qualified default provider name.

[Olivier Tilloy (osomon)]

> I don't believe you need this line? But I'm not an expert and even
> if you don't need it, I think it's harmless, so fine.

I’m not sure either, but I’ll keep it for the sake of consistency with how we’re plugging to the platform snap.

> It's hard to say because this line isn't used by snapd at all yet, but
> I think you just need "mir-libs" here. c.f. the ubuntu-app-platform
> stanza below this one.

You’re probably right. I had just blindly copied what’s in https://bazaar.launchpad.net/~alan-griffiths/mircade-snap/trunk/view/head:/snap/snapcraft.yaml. I guess we’ll find out the day snapd starts making use of that line. I applied your suggestion.

[Michael Terry (mterry)]

Looks good to me! :) Thanks.

review: Approve

=== added directory 'snap/mir-libs'
=== modified file 'snap/snapcraft.yaml'
--- snap/snapcraft.yaml	2017-03-17 17:30:56 +0000
+++ snap/snapcraft.yaml	2017-03-28 14:03:22 +0000
@@ -12,6 +12,7 @@
       - browser-sandbox
       - camera
       - mir
+      - mir-libs
       - network
       - network-bind
       - opengl
@@ -25,6 +26,11 @@
   browser-sandbox:
     interface: browser-support
     allow-sandbox: true
+  mir-libs:
+    content: mir0
+    default-provider: mir-libs
+    interface: content
+    target: mir-libs
   platform:
     content: ubuntu-app-platform1
     default-provider: ubuntu-app-platform