Merge lp:~osomon/webbrowser-app/meet-jit-si-ua-overrides into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 1560
Proposed branch: lp:~osomon/webbrowser-app/meet-jit-si-ua-overrides
Merge into: lp:webbrowser-app
Diff against target: 23 lines (+6/-0)
2 files modified
src/Ubuntu/Web/ua-overrides-desktop.js.in (+3/-0)
src/Ubuntu/Web/ua-overrides-mobile.js.in (+3/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/meet-jit-si-ua-overrides
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+309505@code.launchpad.net

Commit message

Add user agent overrides for meet.jit.si.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1556
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/718/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1915/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1916
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1755
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1755/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1755
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1755/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1755
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1755/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1755/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1755/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1755
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1755/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1755
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1755/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1755/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1755
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1755/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/718/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, this now allows me to start a video call on meet.jit.si using both mobile and desktop ua-overrides.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Web/ua-overrides-desktop.js.in'
2--- src/Ubuntu/Web/ua-overrides-desktop.js.in 2016-10-14 14:37:23 +0000
3+++ src/Ubuntu/Web/ua-overrides-desktop.js.in 2016-10-27 17:20:36 +0000
4@@ -33,4 +33,7 @@
5
6 // Google recaptcha (https://launchpad.net/bugs/1599146)
7 ["^https:\/\/www\.google\.com\/recaptcha\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/${CHROMIUM_VERSION} Safari/537.36"],
8+
9+ // meet.jit.si (https://launchpad.net/bugs/1635971)
10+ ["^https:\/\/meet\.jit\.si\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/${CHROMIUM_VERSION} Safari/537.36"],
11 ];
12
13=== modified file 'src/Ubuntu/Web/ua-overrides-mobile.js.in'
14--- src/Ubuntu/Web/ua-overrides-mobile.js.in 2016-10-14 14:37:23 +0000
15+++ src/Ubuntu/Web/ua-overrides-mobile.js.in 2016-10-27 17:20:36 +0000
16@@ -35,4 +35,7 @@
17
18 // Google recaptcha (https://launchpad.net/bugs/1599146)
19 ["^https:\/\/www\.google\.com\/recaptcha\/", "Mozilla/5.0 (Linux; Ubuntu @UBUNTU_VERSION@ like Android 4.4;) AppleWebKit/537.36 Chrome/${CHROMIUM_VERSION} Safari/537.36"],
20+
21+ // meet.jit.si (https://launchpad.net/bugs/1635971)
22+ ["^https:\/\/meet\.jit\.si\/", "Mozilla/5.0 (Linux; Ubuntu @UBUNTU_VERSION@ like Android 5.0;) AppleWebKit/537.36 Chrome/${CHROMIUM_VERSION} Safari/537.36"],
23 ];

Subscribers

People subscribed via source and target branches

to status/vote changes: