Merge lp:~osomon/webbrowser-app/listitems-now-handle-keyboard-activation into lp:webbrowser-app

[Olivier Tilloy]

The UITK now handles Enter/Return/Space key presses to activate list items,
remove custom implementation.

[system-apps-ci-bot (system-apps-ci-bot)]

FAILED: Continuous integration, rev:1474
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/513/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/515/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/515
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/508
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/508
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/503/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/503/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/513/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'src/app/webbrowser/BookmarksFoldersView.qml'
--- src/app/webbrowser/BookmarksFoldersView.qml	2016-04-15 11:27:13 +0000
+++ src/app/webbrowser/BookmarksFoldersView.qml	2016-06-06 09:12:16 +0000
@@ -229,8 +229,6 @@
                                 event.accepted = false
                             }
                         }
-                        Keys.onEnterPressed: currentItem.clicked()
-                        Keys.onReturnPressed: currentItem.clicked()
                         Keys.onDeletePressed: currentItem.removed()
                     }
                 }

=== modified file 'src/app/webbrowser/BookmarksFoldersViewWide.qml'
--- src/app/webbrowser/BookmarksFoldersViewWide.qml	2016-04-15 11:27:13 +0000
+++ src/app/webbrowser/BookmarksFoldersViewWide.qml	2016-06-06 09:12:16 +0000
@@ -194,7 +194,6 @@
             }
         }
 
-        Keys.onReturnPressed: bookmarksFoldersViewWideItem.bookmarkClicked(currentItem.url)
         Keys.onDeletePressed: {
             if (currentItem.removable) {
                 bookmarksFoldersViewWideItem.bookmarkRemoved(currentItem.url)

=== modified file 'src/app/webbrowser/DownloadsPage.qml'
--- src/app/webbrowser/DownloadsPage.qml	2016-05-05 11:11:01 +0000
+++ src/app/webbrowser/DownloadsPage.qml	2016-06-06 09:12:16 +0000
@@ -228,8 +228,6 @@
             }
         }
 
-        Keys.onEnterPressed: currentItem.clicked()
-        Keys.onReturnPressed: currentItem.clicked()
         Keys.onEscapePressed: {
             if (selectMode) {
                 selectMode = false
@@ -237,11 +235,6 @@
                 event.accepted = false
             }
         }
-        Keys.onSpacePressed: {
-            if (selectMode || pickingMode) {
-                currentItem.clicked()
-            }
-        }
         Keys.onDeletePressed: {
             if (!selectMode && !pickingMode) {
                 currentItem.removed()

=== modified file 'src/app/webbrowser/ExpandedHistoryView.qml'
--- src/app/webbrowser/ExpandedHistoryView.qml	2016-04-15 11:27:13 +0000
+++ src/app/webbrowser/ExpandedHistoryView.qml	2016-06-06 09:12:16 +0000
@@ -79,8 +79,6 @@
             onRemoved: expandedHistoryView.historyEntryRemoved(model.url)
         }
 
-        Keys.onEnterPressed: currentItem.clicked()
-        Keys.onReturnPressed: currentItem.clicked()
         Keys.onDeletePressed: currentItem.removed()
         Keys.onEscapePressed: done()
     }

=== modified file 'src/app/webbrowser/HistoryView.qml'
--- src/app/webbrowser/HistoryView.qml	2016-05-04 09:27:00 +0000
+++ src/app/webbrowser/HistoryView.qml	2016-06-06 09:12:16 +0000
@@ -100,8 +100,6 @@
             }
         }
 
-        Keys.onEnterPressed: currentItem.clicked()
-        Keys.onReturnPressed: currentItem.clicked()
         Keys.onDeletePressed: currentItem.removed()
     }
 

=== modified file 'src/app/webbrowser/HistoryViewWide.qml'
--- src/app/webbrowser/HistoryViewWide.qml	2016-05-05 11:11:01 +0000
+++ src/app/webbrowser/HistoryViewWide.qml	2016-06-06 09:12:16 +0000
@@ -301,9 +301,6 @@
 
                 anchors.fill: parent
 
-                Keys.onReturnPressed: historyEntrySelected()
-                Keys.onEnterPressed: historyEntrySelected()
-
                 model: SortFilterModel {
                     id: historyLastVisitDateModel
                     readonly property date lastVisitDate: lastVisitDateListView.currentItem ? lastVisitDateListView.currentItem.lastVisitDate : ""
@@ -330,14 +327,6 @@
                     }
                 }
 
-                function historyEntrySelected() {
-                    if (urlsListView.ViewItems.selectMode) {
-                        currentItem.selected = !currentItem.selected
-                    } else {
-                        historyViewWide.historyEntryClicked(currentItem.siteUrl)
-                    }
-                }
-
                 // Only use sections for "All History" history list
                 section.property: historyLastVisitDateModel.lastVisitDate.isValid() ? "" : "lastVisitDate"
                 section.delegate: HistorySectionDelegate {

=== modified file 'src/app/webbrowser/NewTabView.qml'
--- src/app/webbrowser/NewTabView.qml	2016-04-15 11:38:07 +0000
+++ src/app/webbrowser/NewTabView.qml	2016-06-06 09:12:16 +0000
@@ -261,8 +261,6 @@
                         }
                     }
 
-                    Keys.onEnterPressed: currentItem.clicked()
-                    Keys.onReturnPressed: currentItem.clicked()
                     Keys.onDeletePressed: currentItem.removed()
 
                     // Setting 'interactive' to false to prevent flicks also disables