Merge lp:~osomon/webbrowser-app/increase-test-timeout into lp:webbrowser-app

[Olivier Tilloy]

Increase significantly the timeout for a bunch of flaky tests,
in the hope that it will make them more robust.

[system-apps-ci-bot (system-apps-ci-bot)]

FAILED: Continuous integration, rev:1501
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/566/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/865/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/865
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/785
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/785
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/785
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/787/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/787/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/787
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/787/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/787
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/787/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/787
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/787/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/787
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/787/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/787
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/787/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/787/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/787
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/787/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/566/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

This obviously doesn’t address the issue, the problem is probably not a too short timeout.

review: Disapprove

Unmerged revisions

1501. By Olivier Tilloy on 2016-07-06

Increase significantly the timeout for a bunch of flaky tests,
in the hope that it will make them more robust.

=== modified file 'tests/unittests/qml/tst_UbuntuWebView02.qml'
--- tests/unittests/qml/tst_UbuntuWebView02.qml	2015-08-27 13:09:40 +0000
+++ tests/unittests/qml/tst_UbuntuWebView02.qml	2016-07-06 20:16:39 +0000
@@ -87,7 +87,7 @@
 
         function test_no_contextual_actions() {
             webview.loadHtml(root.htmlWithHyperlink, "file:///")
-            tryCompare(webview, "loading", false)
+            tryCompare(webview, "loading", false, 20000)
             rightClickWebview()
             compare(getContextMenu(), null)
         }
@@ -95,7 +95,7 @@
         function test_contextual_actions() {
             webview.contextualActions = actionList
             webview.loadHtml(root.htmlWithHyperlink, "file:///")
-            tryCompare(webview, "loading", false)
+            tryCompare(webview, "loading", false, 20000)
             rightClickWebview()
             compare(getContextMenu().actions, actionList)
             compare(webview.contextualData.href, "http://example.org/")
@@ -108,7 +108,7 @@
             action1.enabled = false
             action2.enabled = false
             webview.loadHtml(root.htmlWithHyperlink, "file:///")
-            tryCompare(webview, "loading", false)
+            tryCompare(webview, "loading", false, 20000)
             rightClickWebview()
             compare(getContextMenu(), null)
             action1.enabled = true