Merge lp:~osomon/webbrowser-app/increase-test-timeout into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Günter Schwann
Approved revision: no longer in the source branch.
Merged at revision: 213
Proposed branch: lp:~osomon/webbrowser-app/increase-test-timeout
Merge into: lp:webbrowser-app
Diff against target: 11 lines (+1/-1)
1 file modified
tests/autopilot/webbrowser_app/tests/test_progressbar.py (+1/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/increase-test-timeout
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Günter Schwann (community) Approve
Review via email: mp+173183@code.launchpad.net

Commit message

10 seconds was too much, as it’s also the timeout threshold for the Eventually matcher that verifies that the page has loaded.
Lowering the page load time to 8 seconds should do the trick.

To post a comment you must log in.
Revision history for this message
Günter Schwann (schwann) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
212. By Olivier Tilloy

Disable the current webview while the activity view is visible, thus avoiding mouse events to go through.

Approved by PS Jenkins bot, Günter Schwann.

213. By Olivier Tilloy

10 seconds was too much, as it’s also the timeout threshold for the Eventually matcher that verifies that the page has loaded.
Lowering the page load time to 8 seconds should do the trick.

Approved by PS Jenkins bot, Günter Schwann.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/webbrowser_app/tests/test_progressbar.py'
2--- tests/autopilot/webbrowser_app/tests/test_progressbar.py 2013-07-04 08:19:14 +0000
3+++ tests/autopilot/webbrowser_app/tests/test_progressbar.py 2013-07-05 10:59:27 +0000
4@@ -27,7 +27,7 @@
5
6 def setUp(self):
7 self.base_url = "http://localhost:%d" % HTTP_SERVER_PORT
8- self.url = self.base_url + "/wait/10"
9+ self.url = self.base_url + "/wait/8"
10 self.ARGS = [self.url]
11 super(TestProgressBarAtStartup, self).setUp()
12

Subscribers

People subscribed via source and target branches

to status/vote changes: