Merge lp:~osomon/webbrowser-app/improve-ap-test-robustness into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 721
Merged at revision: 742
Proposed branch: lp:~osomon/webbrowser-app/improve-ap-test-robustness
Merge into: lp:webbrowser-app
Diff against target: 13 lines (+1/-2)
1 file modified
tests/autopilot/webbrowser_app/tests/test_history.py (+1/-2)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/improve-ap-test-robustness
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+236064@code.launchpad.net

Commit message

Make an autopilot test more robust by ensuring that the drawer menu is dismissed but not clicked.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/webbrowser_app/tests/test_history.py'
2--- tests/autopilot/webbrowser_app/tests/test_history.py 2014-08-14 12:12:57 +0000
3+++ tests/autopilot/webbrowser_app/tests/test_history.py 2014-09-26 06:39:24 +0000
4@@ -130,8 +130,7 @@
5 self.pointing_device.click_object(drawer_button)
6 chrome.get_drawer()
7 self.assert_suggestions_eventually_hidden()
8- webview = self.main_window.get_current_webview()
9- self.pointing_device.click_object(webview)
10+ self.focus_address_bar()
11 self.assert_suggestions_eventually_shown()
12
13 def test_select_suggestion(self):

Subscribers

People subscribed via source and target branches

to status/vote changes: