webbrowser-app

Code review comment for lp:~osomon/webbrowser-app/historyUpdateOnLoadCommitted

  1. historyUpdateOnLoadCommitted
  2. Merge into trunk
Riccardo Padovani (rpadovani) wrote :

+ browser.historyModel.add(webviewInternal.storedUrl, webviewInternal.storedTitle, icon)

Why this and not

browser.historyModel.add(webviewInternal.storedUrl, title, icon)

?

I mean, we're updating the database, it's better to do it with last data we have, isn't it?

review: Needs Information

« Back to merge proposal