Merge lp:~osomon/webbrowser-app/header-title-workaround into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 496
Merged at revision: 496
Proposed branch: lp:~osomon/webbrowser-app/header-title-workaround
Merge into: lp:webbrowser-app
Diff against target: 14 lines (+4/-0)
1 file modified
src/app/webbrowser/Browser.qml (+4/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/header-title-workaround
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
David Barth (community) Approve
Review via email: mp+215639@code.launchpad.net

Commit message

Force the page title to be reset to an empty string when the activity view is being hidden.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:496
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/752/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4817
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/4166/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-ci/254
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/254
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/254/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-ci/254
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/4163
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4949
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4949/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4394
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4394/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6399/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5997

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/752/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
David Barth (dbarth) wrote :

This fixes the issue for me.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2014-03-17 22:16:59 +0000
3+++ src/app/webbrowser/Browser.qml 2014-04-14 11:01:24 +0000
4@@ -59,6 +59,10 @@
5 PageStack {
6 id: stack
7 Page {
8+ // Work around http://pad.lv/1305834 by forcing the page title to be
9+ // reset to an empty string when the activity view is being hidden.
10+ title: activityViewVisible ? " " : ""
11+
12 Item {
13 id: webviewContainer
14 anchors {

Subscribers

People subscribed via source and target branches

to status/vote changes: