Merge lp:~osomon/webbrowser-app/focus-fix-suggestions-list into lp:webbrowser-app

[Olivier Tilloy]

Transfer focus to the webview when validating an entry from the suggestions list.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:155
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/117/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-amd64-ci/79
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-armhf-ci/114
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-armhf-ci/114/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-i386-ci/114
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1798

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/117/rebuild

review: Approve (continuous-integration)

[Ugo Riboni (uriboni)]

Code looks good and tests pass, also manually confirmed on desktop.

review: Approve

=== modified file 'src/Ubuntu/Browser/Browser.qml'
--- src/Ubuntu/Browser/Browser.qml	2013-05-31 16:55:20 +0000
+++ src/Ubuntu/Browser/Browser.qml	2013-05-31 17:48:26 +0000
@@ -359,7 +359,10 @@
             }
             width: panel.width - units.gu(5)
             height: Math.min(contentHeight, panel.y - units.gu(2))
-            onSelected: browser.url = url
+            onSelected: {
+                browser.url = url
+                webview.forceActiveFocus()
+            }
         }
 
         KeyboardRectangle {

=== modified file 'tests/autopilot/webbrowser_app/tests/test_history.py'
--- tests/autopilot/webbrowser_app/tests/test_history.py	2013-05-31 09:06:19 +0000
+++ tests/autopilot/webbrowser_app/tests/test_history.py	2013-05-31 17:48:26 +0000
@@ -131,3 +131,4 @@
         webview = self.main_window.get_web_view()
         url = "http://en.wikipedia.org/wiki/Ubuntu_(operating_system)"
         self.assertThat(webview.url, Eventually(Equals(url)))
+        self.assertThat(suggestions.visible, Eventually(Equals(False)))