Merge lp:~osomon/webbrowser-app/fix-tabsmodel-ut-qt56 into lp:webbrowser-app

Proposed by Olivier Tilloy on 2016-04-04
Status: Merged
Approved by: Olivier Tilloy on 2016-04-06
Approved revision: 1393
Merged at revision: 1410
Proposed branch: lp:~osomon/webbrowser-app/fix-tabsmodel-ut-qt56
Merge into: lp:webbrowser-app
Diff against target: 23 lines (+2/-2)
1 file modified
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+2/-2)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/fix-tabsmodel-ut-qt56
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing on 2016-04-06
Ubuntu Phablet Team 2016-04-04 Pending
Review via email: mp+290862@code.launchpad.net

Commit Message

Fix a failing unit test with Qt 5.6.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/unittests/tabs-model/tst_TabsModelTests.cpp'
2--- tests/unittests/tabs-model/tst_TabsModelTests.cpp 2015-12-03 11:20:43 +0000
3+++ tests/unittests/tabs-model/tst_TabsModelTests.cpp 2016-04-04 10:22:23 +0000
4@@ -1,5 +1,5 @@
5 /*
6- * Copyright 2013-2015 Canonical Ltd.
7+ * Copyright 2013-2016 Canonical Ltd.
8 *
9 * This file is part of webbrowser-app.
10 *
11@@ -33,11 +33,11 @@
12 Q_OBJECT
13
14 private:
15+ QQmlEngine engine;
16 TabsModel* model;
17
18 QQuickItem* createTab()
19 {
20- QQmlEngine engine;
21 QQmlComponent component(&engine);
22 QByteArray data("import QtQuick 2.4\nItem {\nproperty url url\n"
23 "property string title\nproperty url icon\n}");

Subscribers

People subscribed via source and target branches

to status/vote changes: