Merge lp:~osomon/webbrowser-app/fix-main-page-dimensions into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 550
Proposed branch: lp:~osomon/webbrowser-app/fix-main-page-dimensions
Merge into: lp:webbrowser-app
Diff against target: 14 lines (+2/-0)
1 file modified
src/app/webbrowser/Browser.qml (+2/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/fix-main-page-dimensions
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+220944@code.launchpad.net

Commit message

Ensure the main page that contains the webviews fills the main view.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
549. By Olivier Tilloy

Merge the latest changes from trunk and resolve a conflict.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2014-05-26 10:54:13 +0000
3+++ src/app/webbrowser/Browser.qml 2014-05-26 13:25:47 +0000
4@@ -60,8 +60,10 @@
5 // Work around http://pad.lv/1305834 by forcing the page title to be
6 // reset to an empty string when the activity view is being hidden.
7 title: activityViewVisible ? " " : ""
8+ anchors.fill: parent
9 visible: !activityViewVisible
10 active: visible
11+
12 Item {
13 id: webviewContainer
14 anchors {

Subscribers

People subscribed via source and target branches

to status/vote changes: