webbrowser-app

Merge lp:~osomon/webbrowser-app/delay-showing-fullscreen-hint into lp:webbrowser-app

  1. delay-showing-fullscreen-hint
  2. Merge into trunk
Proposed by Olivier Tilloy on 2015-05-12
Status: Merged
Approved by: Ugo Riboni on 2015-05-13
Approved revision: 1003
Merged at revision: 1013
Proposed branch: lp:~osomon/webbrowser-app/delay-showing-fullscreen-hint
Merge into: lp:webbrowser-app
Diff against target: 28 lines (+10/-1)
1 file modified
src/app/webbrowser/Browser.qml (+10/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/delay-showing-fullscreen-hint
Reviewer Review Type Date Requested Status
Ugo Riboni (community) 2015-05-12 Approve on 2015-05-13
PS Jenkins bot continuous-integration Needs Fixing on 2015-05-12
Review via email: mp+258839@code.launchpad.net

Commit Message

Delay showing the fullscreen hint to prevent it from jumping up while the webview is being resized.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2015-05-06 21:51:16 +0000
3+++ src/app/webbrowser/Browser.qml 2015-05-12 07:46:41 +0000
4@@ -719,6 +719,15 @@
5 }
6 }
7
8+ // Delay showing the hint to prevent it from jumping up while the
9+ // webview is being resized (https://launchpad.net/bugs/1454097).
10+ visible: false
11+ Timer {
12+ running: true
13+ interval: 250
14+ onTriggered: fullscreenExitHint.visible = true
15+ }
16+
17 Label {
18 color: "white"
19 font.weight: Font.Light
20@@ -729,7 +738,7 @@
21 }
22
23 Timer {
24- running: true
25+ running: fullscreenExitHint.visible
26 interval: 2000
27 onTriggered: fullscreenExitHint.opacity = 0
28 }

Subscribers

People subscribed via source and target branches

to status/vote changes: