Merge lp:~osomon/webbrowser-app/cleaner-workaround-1248620 into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Ugo Riboni
Approved revision: 404
Merged at revision: 406
Proposed branch: lp:~osomon/webbrowser-app/cleaner-workaround-1248620
Merge into: lp:webbrowser-app
Diff against target: 12 lines (+2/-2)
1 file modified
tests/autopilot/webbrowser_app/tests/test_title.py (+2/-2)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/cleaner-workaround-1248620
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+194455@code.launchpad.net

Commit message

Cleaner workaround for bug #1248620.
Thanks Thomi for the suggestion!

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/webbrowser_app/tests/test_title.py'
2--- tests/autopilot/webbrowser_app/tests/test_title.py 2013-11-06 12:43:45 +0000
3+++ tests/autopilot/webbrowser_app/tests/test_title.py 2013-11-08 07:17:09 +0000
4@@ -28,6 +28,6 @@
5 # One is the correct one, and the other one is not visible, its
6 # dimensions are 0×0, it has no title, its parent is the webbrowser-app
7 # object, and it has no children.
8- windows = self.app.select_many("QQuickWindow")
9- window = [w for w in windows if w.visible][0]
10+ # See https://bugs.launchpad.net/bugs/1248620.
11+ window = self.app.select_single("QQuickWindow", visible=True)
12 self.assertThat(window.title, Eventually(Contains(title)))

Subscribers

People subscribed via source and target branches

to status/vote changes: