Merge lp:~osomon/webbrowser-app/chrome-buttons-pressed-state into lp:webbrowser-app

[Olivier Tilloy]

Visual feedback for pressed state of chrome buttons and drawer menu entries.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:989
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1719/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2587/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/476
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/476
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/476/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/476/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2241/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2585
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2585/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20114

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1719/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'src/app/ChromeButton.qml'
--- src/app/ChromeButton.qml	2014-07-29 21:51:07 +0000
+++ src/app/ChromeButton.qml	2015-04-30 22:45:11 +0000
@@ -23,6 +23,12 @@
     property real iconSize: width
     property alias iconName: icon.name
 
+    Rectangle {
+        anchors.fill: parent
+        color: Theme.palette.selected.background
+        visible: parent.pressed
+    }
+
     Icon {
         id: icon
         anchors.centerIn: parent

=== modified file 'src/app/webbrowser/Chrome.qml'
--- src/app/webbrowser/Chrome.qml	2015-03-23 07:49:08 +0000
+++ src/app/webbrowser/Chrome.qml	2015-04-30 22:45:11 +0000
@@ -43,10 +43,10 @@
             objectName: "backButton"
 
             iconName: "previous"
-            iconSize: 0.6 * height
+            iconSize: 0.4 * height
 
-            height: parent.height
-            width: height
+            height: chrome.height
+            width: height * 0.8
 
             anchors {
                 left: parent.left
@@ -62,11 +62,11 @@
             objectName: "forwardButton"
 
             iconName: "next"
-            iconSize: 0.6 * height
+            iconSize: 0.4 * height
 
-            height: parent.height
+            height: chrome.height
             visible: enabled
-            width: visible ? height : 0
+            width: visible ? height * 0.8 : 0
 
             anchors {
                 left: backButton.right
@@ -127,10 +127,10 @@
             objectName: "drawerButton"
 
             iconName: "contextual-menu"
-            iconSize: 0.75 * height
+            iconSize: 0.5 * height
 
-            height: parent.height
-            width: height
+            height: chrome.height
+            width: height * 0.8
 
             anchors {
                 right: parent.right
@@ -244,6 +244,12 @@
                         action: modelData
                         onClicked: drawer.opened = false
 
+                        Rectangle {
+                            anchors.fill: parent
+                            color: Theme.palette.selected.background
+                            visible: parent.pressed
+                        }
+
                         Icon {
                             id: actionIcon
                             anchors {