Merge lp:~osomon/webbrowser-app/bottom-edge into lp:webbrowser-app
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Olivier Tilloy on 2015-03-20 | ||||
| Approved revision: | 955 | ||||
| Merged at revision: | 935 | ||||
| Proposed branch: | lp:~osomon/webbrowser-app/bottom-edge | ||||
| Merge into: | lp:webbrowser-app | ||||
| Diff against target: |
6448 lines (+5313/-361) 62 files modified
CMakeLists.txt (+3/-0) debian/control (+2/-0) src/app/CMakeLists.txt (+6/-0) src/app/browserapplication.cpp (+17/-0) src/app/favicon-fetcher.h (+1/-1) src/app/unity8/CMakeLists.txt (+4/-0) src/app/unity8/README (+11/-0) src/app/unity8/libs/CMakeLists.txt (+1/-0) src/app/unity8/libs/UbuntuGestures/CMakeLists.txt (+36/-0) src/app/unity8/libs/UbuntuGestures/CandidateInactivityTimer.cpp (+41/-0) src/app/unity8/libs/UbuntuGestures/CandidateInactivityTimer.h (+49/-0) src/app/unity8/libs/UbuntuGestures/DebugHelpers.cpp (+95/-0) src/app/unity8/libs/UbuntuGestures/DebugHelpers.h (+31/-0) src/app/unity8/libs/UbuntuGestures/Pool.h (+132/-0) src/app/unity8/libs/UbuntuGestures/Timer.cpp (+109/-0) src/app/unity8/libs/UbuntuGestures/Timer.h (+105/-0) src/app/unity8/libs/UbuntuGestures/TouchOwnershipEvent.cpp (+35/-0) src/app/unity8/libs/UbuntuGestures/TouchOwnershipEvent.h (+50/-0) src/app/unity8/libs/UbuntuGestures/TouchRegistry.cpp (+500/-0) src/app/unity8/libs/UbuntuGestures/TouchRegistry.h (+182/-0) src/app/unity8/libs/UbuntuGestures/UbuntuGesturesGlobal.h (+23/-0) src/app/unity8/libs/UbuntuGestures/UnownedTouchEvent.cpp (+39/-0) src/app/unity8/libs/UbuntuGestures/UnownedTouchEvent.h (+45/-0) src/app/unity8/plugins/CMakeLists.txt (+1/-0) src/app/unity8/plugins/Ubuntu/CMakeLists.txt (+1/-0) src/app/unity8/plugins/Ubuntu/Gestures/AxisVelocityCalculator.cpp (+149/-0) src/app/unity8/plugins/Ubuntu/Gestures/AxisVelocityCalculator.h (+146/-0) src/app/unity8/plugins/Ubuntu/Gestures/CMakeLists.txt (+40/-0) src/app/unity8/plugins/Ubuntu/Gestures/Damper.h (+87/-0) src/app/unity8/plugins/Ubuntu/Gestures/Direction.cpp (+36/-0) src/app/unity8/plugins/Ubuntu/Gestures/Direction.h (+45/-0) src/app/unity8/plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+886/-0) src/app/unity8/plugins/Ubuntu/Gestures/DirectionalDragArea.h (+308/-0) src/app/unity8/plugins/Ubuntu/Gestures/Gestures.qmltypes (+168/-0) src/app/unity8/plugins/Ubuntu/Gestures/PressedOutsideNotifier.cpp (+119/-0) src/app/unity8/plugins/Ubuntu/Gestures/PressedOutsideNotifier.h (+62/-0) src/app/unity8/plugins/Ubuntu/Gestures/TimeSource.cpp (+49/-0) src/app/unity8/plugins/Ubuntu/Gestures/TimeSource.h (+54/-0) src/app/unity8/plugins/Ubuntu/Gestures/TouchDispatcher.cpp (+367/-0) src/app/unity8/plugins/Ubuntu/Gestures/TouchDispatcher.h (+89/-0) src/app/unity8/plugins/Ubuntu/Gestures/TouchGate.cpp (+253/-0) src/app/unity8/plugins/Ubuntu/Gestures/TouchGate.h (+112/-0) src/app/unity8/plugins/Ubuntu/Gestures/UbuntuGesturesQmlGlobal.h (+23/-0) src/app/unity8/plugins/Ubuntu/Gestures/plugin.cpp (+39/-0) src/app/unity8/plugins/Ubuntu/Gestures/plugin.h (+31/-0) src/app/unity8/plugins/Ubuntu/Gestures/qmldir (+3/-0) src/app/webbrowser/BottomEdgeHandle.qml (+36/-0) src/app/webbrowser/Browser.qml (+190/-26) src/app/webbrowser/BrowserTab.qml (+13/-4) src/app/webbrowser/ExpandedHistoryView.qml (+2/-2) src/app/webbrowser/HistorySectionDelegate.qml (+2/-2) src/app/webbrowser/HistoryView.qml (+2/-2) src/app/webbrowser/TabChrome.qml (+144/-0) src/app/webbrowser/TabPreview.qml (+67/-121) src/app/webbrowser/TabsList.qml (+130/-0) src/app/webbrowser/TabsView.qml (+0/-123) src/app/webbrowser/Toolbar.qml (+36/-1) src/app/webbrowser/UrlDelegate.qml (+3/-3) tests/autopilot/webbrowser_app/emulators/browser.py (+44/-22) tests/autopilot/webbrowser_app/tests/__init__.py (+20/-10) tests/autopilot/webbrowser_app/tests/test_addressbar_bookmark.py (+9/-13) tests/autopilot/webbrowser_app/tests/test_tabs.py (+30/-31) |
||||
| To merge this branch: | bzr merge lp:~osomon/webbrowser-app/bottom-edge | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Florian Boucault (community) | Approve on 2015-03-20 | ||
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-03-19 | |
| Ken VanDine | 2015-01-29 | Approve on 2015-03-19 | |
| Bartosz Kosiorek (community) | Needs Information on 2015-02-10 | ||
|
Review via email:
|
|||
Commit Message
On mobile, reveal the tabs view with a swipe gesture from the bottom edge.
Note: this re-adds qtbase5-private-dev and qtdeclarative5-
Description of the Change
On mobile, reveal the tabs view with a swipe gesture from the bottom edge.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:899
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:899
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:900
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:901
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:902
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:903
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:904
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:905
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:907
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:911
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:912
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:913
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:914
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| Bartosz Kosiorek (gang65) wrote : | # |
Hello Olivier.
Thanks for this MR. It is most wanted feature in WebBrowser.
One small remark:
Could you please update README file, because executable location was changed.
To run you should type:
./src/app/
Do you think it will be possible to use gestures on Desktop?
I'm unable to show up tabs from bottom edge.
| Olivier Tilloy (osomon) wrote : | # |
> Hello Olivier.
> Thanks for this MR. It is most wanted feature in WebBrowser.
>
> One small remark:
> Could you please update README file, because executable location was changed.
> To run you should type:
>
> ./src/app/
The README file is already up-to-date in this regard.
> Do you think it will be possible to use gestures on Desktop?
> I'm unable to show up tabs from bottom edge.
No, by design this is meant to work on mobile only. In the future the desktop UX will gain visible tabs, much like other desktop browsers do.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:915
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:938
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:940
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:940
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:940
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:942
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:943
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Florian Boucault (fboucault) wrote : | # |
* tests/autopilot
- Factor duplicated code to swipe up from the bottom in a common function
* src/app/
- #5d5d5d is UbuntuColors.
* src/app/
- generally better for components to not define their own width/height but instead implicitWidth/
- "AbstractButton { id: closeButton" should use anchors instead of "height: parent.height"; same for unnamed Item below
- closeButton has a Rectangle without color
- closeButton has no visual feedback when pressing
- Images "tabBackgroundL
- "MouseArea.width: parent.width / 2" should probably have a comment

FAILED: Continuous integration, rev:888 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 1419/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1080 jenkins. qa.ubuntu. com/job/ generic- mediumtests- vivid/505 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- amd64-ci/ 177 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 177 jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 177/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- i386-ci/ 177 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 959 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1078 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1078/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 17614 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-vivid/ 409 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-amd64/ 613 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-amd64/ 613/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/webbrowser- app-ci/ 1419/rebuild
http://