Merge lp:~osomon/webbrowser-app/bottom-edge-mouse into lp:webbrowser-app
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Olivier Tilloy on 2016-01-29 | ||||
| Approved revision: | 1340 | ||||
| Merged at revision: | 1339 | ||||
| Proposed branch: | lp:~osomon/webbrowser-app/bottom-edge-mouse | ||||
| Merge into: | lp:webbrowser-app | ||||
| Diff against target: |
1518 lines (+1284/-27) 19 files modified
debian/control (+3/-0) debian/rules (+3/-1) debian/webbrowser-app-apparmor.manifest (+2/-1) src/app/CMakeLists.txt (+1/-0) src/app/browserapplication.cpp (+5/-0) src/app/unity8/README (+11/-3) src/app/unity8/plugins/CMakeLists.txt (+1/-0) src/app/unity8/plugins/Unity/CMakeLists.txt (+1/-0) src/app/unity8/plugins/Unity/InputInfo/CMakeLists.txt (+40/-0) src/app/unity8/plugins/Unity/InputInfo/linux/qinputdeviceinfo_linux.cpp (+291/-0) src/app/unity8/plugins/Unity/InputInfo/linux/qinputdeviceinfo_linux_p.h (+98/-0) src/app/unity8/plugins/Unity/InputInfo/plugin.cpp (+32/-0) src/app/unity8/plugins/Unity/InputInfo/plugin.h (+30/-0) src/app/unity8/plugins/Unity/InputInfo/qdeclarativeinputdevicemodel.cpp (+196/-0) src/app/unity8/plugins/Unity/InputInfo/qdeclarativeinputdevicemodel_p.h (+102/-0) src/app/unity8/plugins/Unity/InputInfo/qinputinfo.cpp (+270/-0) src/app/unity8/plugins/Unity/InputInfo/qinputinfo.h (+143/-0) src/app/unity8/plugins/Unity/InputInfo/qmldir (+3/-0) src/app/webbrowser/Browser.qml (+52/-22) |
||||
| To merge this branch: | bzr merge lp:~osomon/webbrowser-app/bottom-edge-mouse | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing on 2016-01-29 | |
| Jamie Strandboge | 2016-01-28 | Approve on 2016-01-28 | |
|
Review via email:
|
|||
Commit Message
In narrow mode, when a mouse is connected, turn the bottom edge hint into a clickable bottom edge bar.
- 1332. By Olivier Tilloy on 2016-01-28
-
Add missing build dependency.
- 1333. By Olivier Tilloy on 2016-01-28
-
In narrow mode, when a mouse is connected, turn the bottom edge hint into a clickable bottom edge bar.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1332
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1334. By Olivier Tilloy on 2016-01-28
-
Merge the latest changes from trunk, and resolve a minor conflict.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1333
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Olivier Tilloy (osomon) wrote : | # |
Testing on device, I’m getting apparmor denials which prevent the Unity.InputInfo plugin from working. Disabling the apparmor profile makes it work.
The following additional rules appear to be needed:
/sys/class/ r,
/sys/class/input/ r,
/sys/
/sys/
- 1335. By Olivier Tilloy on 2016-01-28
-
Remove the "Open tabs" and "New tab" actions from the drawer menu.
- In wide mode, they are useless because there is a visible tab bar.
- In narrow mode, if there is a mouse connected the bottom edge bar opens the tabs view, and if there is no mouse the bottom edge hint opens it. - 1336. By Olivier Tilloy on 2016-01-28
-
Also detect touchpads.
- 1337. By Olivier Tilloy on 2016-01-28
-
Add apparmor rules to allow InputInfo to work.
| Jamie Strandboge (jdstrand) wrote : | # |
With the "/sys/devices/
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1334
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1338. By Olivier Tilloy on 2016-01-28
-
Simpler sed rule.
| Jamie Strandboge (jdstrand) wrote : | # |
FYI, the other changes to debian/ look good too.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1337
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1338
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 1339. By Olivier Tilloy on 2016-01-29
-
Escape $ in debian/rules.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1339
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1340. By Olivier Tilloy on 2016-01-29
-
Also allow read access to /run/udev/data/**, so that input device capabilities can be discovered.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1340
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

FAILED: Continuous integration, rev:1331 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 2584/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 6239/console jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- amd64-ci/ 1337/console jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- armhf-ci/ 1337/console jenkins. qa.ubuntu. com/job/ webbrowser- app-vivid- i386-ci/ 1337/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 6250/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/webbrowser- app-ci/ 2584/rebuild
http://