Merge lp:~osomon/webbrowser-app/better-ua-override-for-twitter into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Günter Schwann
Approved revision: 373
Merged at revision: 374
Proposed branch: lp:~osomon/webbrowser-app/better-ua-override-for-twitter
Merge into: lp:webbrowser-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/Ubuntu/Components/Extras/Browser/ua-overrides.js (+1/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/better-ua-override-for-twitter
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Günter Schwann (community) Approve
Review via email: mp+189540@code.launchpad.net

Commit message

Better UA override rule for mobile twitter (don’t pretend to be an android).
Thanks Adnane Belmadiaf for the tip!

To post a comment you must log in.
Revision history for this message
Günter Schwann (schwann) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Extras/Browser/ua-overrides.js'
2--- src/Ubuntu/Components/Extras/Browser/ua-overrides.js 2013-10-03 17:38:29 +0000
3+++ src/Ubuntu/Components/Extras/Browser/ua-overrides.js 2013-10-07 08:11:26 +0000
4@@ -56,7 +56,7 @@
5
6 "m.youtube.com": [/Mobile\) WebKit\/[.0-9]*/, "Android 4.3) AppleWebKit Mobile Safari"],
7
8- "mobile.twitter.com": [/Mobile\) WebKit\/[.0-9]*/, "Android 4.3) AppleWebKit Mobile Safari"],
9+ "twitter.com": ["Mobile)", "Mobile) Firefox"],
10
11 // while this issue gets resolved (https://bugs.launchpad.net/ubuntu/+source/ubuntu-keyboard/+bug/1233207)
12 "login.ubuntu.com": [/Mobile\) WebKit\/[.0-9]*/, "Android 4.3) AppleWebKit Mobile Safari"],

Subscribers

People subscribed via source and target branches

to status/vote changes: