Merge lp:~osomon/webbrowser-app/autopilot-fixes-desktop-narrow-mode into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1238
Merged at revision: 1241
Proposed branch: lp:~osomon/webbrowser-app/autopilot-fixes-desktop-narrow-mode
Merge into: lp:webbrowser-app
Diff against target: 31 lines (+10/-3)
1 file modified
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+10/-3)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/autopilot-fixes-desktop-narrow-mode
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+274719@code.launchpad.net

Commit message

Fix a couple of autopilot failures on desktop in narrow mode.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/webbrowser_app/tests/test_keyboard.py'
2--- tests/autopilot/webbrowser_app/tests/test_keyboard.py 2015-09-29 13:15:01 +0000
3+++ tests/autopilot/webbrowser_app/tests/test_keyboard.py 2015-10-16 14:38:05 +0000
4@@ -105,9 +105,15 @@
5 self.main_window.press_key('Ctrl+Page_Down')
6 self.check_tab_number(0)
7 self.main_window.press_key('Shift+Ctrl+Tab')
8- self.check_tab_number(2)
9+ if self.main_window.wide:
10+ self.check_tab_number(2)
11+ else:
12+ self.check_tab_number(1)
13 self.main_window.press_key('Ctrl+Page_Up')
14- self.check_tab_number(1)
15+ if self.main_window.wide:
16+ self.check_tab_number(1)
17+ else:
18+ self.check_tab_number(2)
19
20 def test_can_switch_tabs_after_suggestions_escape(self):
21 self.open_tabs(1)
22@@ -308,7 +314,8 @@
23 self.assertThat(address_bar.findInPageMode, Eventually(Equals(True)))
24 self.main_window.press_key('Escape')
25 self.assertThat(address_bar.findInPageMode, Eventually(Equals(False)))
26-
27+ if not self.main_window.wide:
28+ self.open_tabs_view()
29 self.open_new_tab()
30 self.main_window.press_key('Ctrl+F')
31 self.assertThat(address_bar.findInPageMode, Equals(False))

Subscribers

People subscribed via source and target branches

to status/vote changes: