webbrowser-app

Merge lp:~osomon/webbrowser-app/OxideQQuickScriptMessage-deprecated-args into lp:webbrowser-app/staging

  1. OxideQQuickScriptMessage-deprecated-args
  2. Merge into staging
Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 1589
Proposed branch: lp:~osomon/webbrowser-app/OxideQQuickScriptMessage-deprecated-args
Merge into: lp:webbrowser-app/staging
Diff against target: 11 lines (+1/-1)
1 file modified
src/app/webcontainer/WebViewImplOxide.qml (+1/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/OxideQQuickScriptMessage-deprecated-args
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Approve
Review via email: mp+313552@code.launchpad.net

Commit message

Stop using a deprecated API.

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, also checked the value of payload is actually the same as args :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webcontainer/WebViewImplOxide.qml'
2--- src/app/webcontainer/WebViewImplOxide.qml 2016-09-20 15:32:49 +0000
3+++ src/app/webcontainer/WebViewImplOxide.qml 2016-12-19 17:06:24 +0000
4@@ -103,7 +103,7 @@
5 msgId: "webapp-specific-page-metadata-detected",
6 contexts: ["oxide://webapp-specific-page-metadata-collector/"],
7 callback: function(msg, frame) {
8- handlePageMetadata(msg.args)
9+ handlePageMetadata(msg.payload)
10 }
11 });
12

Subscribers

People subscribed via source and target branches