webbrowser-app

Merge lp:~osomon/webbrowser-app/1634463-focus-transfer into lp:webbrowser-app/staging

  1. 1634463-focus-transfer
  2. Merge into staging
Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 1571
Proposed branch: lp:~osomon/webbrowser-app/1634463-focus-transfer
Merge into: lp:webbrowser-app/staging
Diff against target: 12 lines (+1/-1)
1 file modified
src/app/webbrowser/Browser.qml (+1/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/1634463-focus-transfer
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+308720@code.launchpad.net

Commit message

Do not transfer keyboard focus from the address bar to the new tab view in incognito mode.

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, this resolves the issue stated in the bug :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2016-10-11 16:16:40 +0000
3+++ src/app/webbrowser/Browser.qml 2016-10-18 11:54:55 +0000
4@@ -570,7 +570,7 @@
5
6 Keys.onDownPressed: {
7 if (suggestionsList.count) suggestionsList.focus = true
8- else if (newTabViewLoader.status == Loader.Ready) {
9+ else if (!incognito && (newTabViewLoader.status == Loader.Ready)) {
10 newTabViewLoader.forceActiveFocus()
11 }
12 }

Subscribers

People subscribed via source and target branches