Merge lp:~osomon/webapps-core/gmaps-intent-hook into lp:webapps-core

Proposed by Olivier Tilloy
Status: Needs review
Proposed branch: lp:~osomon/webapps-core/gmaps-intent-hook
Merge into: lp:webapps-core
Diff against target: 37 lines (+9/-2)
3 files modified
webapp-googlemaps/manifest.json (+2/-1)
webapp-googlemaps/webapp-googlemaps.desktop (+1/-1)
webapp-googlemaps/webapp-googlemaps.url-dispatcher (+6/-0)
To merge this branch: bzr merge lp:~osomon/webapps-core/gmaps-intent-hook
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Review via email: mp+245982@code.launchpad.net

Commit message

Add a URL dispatcher hook to the google maps app to handle intent:// URLs targetted at com.google.android.apps.maps.

Description of the change

WARNING: this shouldn’t be published until support for intent URIs in the container has landed in both vivid and RTM!

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) :
review: Approve
107. By Alexandre Abreu

Fix the gmaps URL pattern.

108. By Olivier Tilloy

Add an intent filter function.

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

You dont need the specific local-intent-filter.js file, when an intent uri is met, a default 'identity' filter is applied which basically is the same the one below,

109. By Olivier Tilloy

Remove the custom intent filter as it’s basically the identity function, which the container defaults to already.

Revision history for this message
Olivier Tilloy (osomon) wrote :

> You dont need the specific local-intent-filter.js file, when an intent uri is
> met, a default 'identity' filter is applied which basically is the same the
> one below,

D’oh… Removed, thanks.

Unmerged revisions

109. By Olivier Tilloy

Remove the custom intent filter as it’s basically the identity function, which the container defaults to already.

108. By Olivier Tilloy

Add an intent filter function.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'webapp-googlemaps/manifest.json'
2--- webapp-googlemaps/manifest.json 2014-09-26 10:42:03 +0000
3+++ webapp-googlemaps/manifest.json 2015-02-02 14:22:59 +0000
4@@ -5,7 +5,8 @@
5 "hooks": {
6 "webapp-googlemaps": {
7 "apparmor": "webapp-googlemaps.json",
8- "desktop": "webapp-googlemaps.desktop"
9+ "desktop": "webapp-googlemaps.desktop",
10+ "urls": "webapp-googlemaps.url-dispatcher"
11 }
12 },
13 "maintainer": "Webapps Team <webapps@lists.launchpad.net>",
14
15=== modified file 'webapp-googlemaps/webapp-googlemaps.desktop'
16--- webapp-googlemaps/webapp-googlemaps.desktop 2014-08-11 12:34:54 +0000
17+++ webapp-googlemaps/webapp-googlemaps.desktop 2015-02-02 14:22:59 +0000
18@@ -1,7 +1,7 @@
19 [Desktop Entry]
20 Type=Application
21 Terminal=false
22-Exec=webapp-container --store-session-cookies --webappUrlPatterns=https?://maps.google.*,https://accounts.google.*/*,https://www.google.*/a/*,https://www.google.*/accounts/* https://maps.google.com/ %u
23+Exec=webapp-container --store-session-cookies --webappUrlPatterns=https?://maps.google.*/*,https://accounts.google.*/*,https://www.google.*/a/*,https://www.google.*/accounts/* https://maps.google.com/ %u
24 Name=Google Maps
25 Comment=Google Maps Webapp
26 Icon=./webapp-googlemaps.png
27
28=== added file 'webapp-googlemaps/webapp-googlemaps.url-dispatcher'
29--- webapp-googlemaps/webapp-googlemaps.url-dispatcher 1970-01-01 00:00:00 +0000
30+++ webapp-googlemaps/webapp-googlemaps.url-dispatcher 2015-02-02 14:22:59 +0000
31@@ -0,0 +1,6 @@
32+[
33+ {
34+ "protocol": "intent",
35+ "domain-suffix": "com.google.android.apps.maps"
36+ }
37+]

Subscribers

People subscribed via source and target branches

to all changes: