Code review comment for lp:~osomon/unity-2d/natty-panel-backport-oneiric-changes

Alberto Mardegan (mardy) wrote :

Thanks for this contribution!

The merge of code from the Oneiric branch is obviously fine.

About the ready() signal, while reviewing your code I started thinking about the emission of the signal from the panelManager; I was thinking of having it emitted by the panel subclass after loading the plugins (maybe with QMetaObject::invokeMethod() with a queued connection). And this led me to wonder, do we really need this signal at all? Why can't the plugins themselves call their lengthy methods with a queued connection?

« Back to merge proposal