Code review comment for lp:~osomon/unity-2d/launcher-items-keyboard-shortcuts

Revision history for this message
Olivier Tilloy (osomon) wrote :

This is very likely because your text editor, when you are typing "é", is in fact inserting two characters (0xc3 + 0xa9) instead of one (0xc9). The visual representation is the same, but the underlying unicode representation isn’t, and as a consequence the string extracted from the place file is too long. At least the code now prints out a warning, it doesn’t ignore it silently.

Still, if you use an hexadecimal editor to set the shortcut to the correct unicode character (0xc9), grabbing the key fails lower down the stack with the following warning:

    Could not convert "É" to an x11 keysym

This happens during the conversion from a Qt::Key to an X11 keysym in the constructor for Hotkey. I’m trying to figure out how to fix the conversion.

« Back to merge proposal