Code review comment for lp:~osomon/unity-2d/custom-quicklists-static

Revision history for this message
Florian Boucault (fboucault) wrote :

In launcher/UnityApplications/launchermenu.cpp:

    if (folded) {
        /* Remove all actions but the title. */
        for (int i = actions().size(); i > 0; --i) {
            QAction* action = actions().at(i - 1);

The use of a reverse for loop does not seem necessary. A forward one would be simpler. And even better would be to use a Q_FOREACH.

review: Needs Fixing

« Back to merge proposal