Merge lp:~osomon/unity-2d/apport-hook-check-session into lp:unity-2d/3.0

Proposed by Olivier Tilloy
Status: Rejected
Rejected by: Didier Roche-Tolomelli
Proposed branch: lp:~osomon/unity-2d/apport-hook-check-session
Merge into: lp:unity-2d/3.0
Diff against target: 11 lines (+5/-1)
1 file modified
debian/unity-2d.py (+5/-1)
To merge this branch: bzr merge lp:~osomon/unity-2d/apport-hook-check-session
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Disapprove
Review via email: mp+59195@code.launchpad.net

Commit message

Add the "unity-2d" tag to apport crash reports only if the session actually is "Unity 2D".

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

as discussed on IRC, it will be handled differently in oneiric with lightdm

review: Disapprove

Unmerged revisions

549. By Olivier Tilloy

Add the "unity-2d" tag to apport crash reports only if the session actually is "Unity 2D".

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/unity-2d.py'
2--- debian/unity-2d.py 2011-01-26 11:34:38 +0000
3+++ debian/unity-2d.py 2011-04-27 10:15:49 +0000
4@@ -1,2 +1,6 @@
5+import os
6+
7 def add_info(report):
8- report['Tags'] = report.get('Tags', '') + ' unity-2d'
9+ if os.getenv('GDMSESSION') == 'unity-2d':
10+ report.setdefault('Tags', '')
11+ report['Tags'] += ' unity-2d'

Subscribers

People subscribed via source and target branches