Merge lp:~osomon/ubuntu-ui-toolkit/staging-fix-1495641 into lp:ubuntu-ui-toolkit/staging

Proposed by Olivier Tilloy
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1634
Merged at revision: 1634
Proposed branch: lp:~osomon/ubuntu-ui-toolkit/staging-fix-1495641
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 16 lines (+5/-2)
1 file modified
src/Ubuntu/Components/plugin/sortfiltermodel.cpp (+5/-2)
To merge this branch: bzr merge lp:~osomon/ubuntu-ui-toolkit/staging-fix-1495641
Reviewer Review Type Date Requested Status
Zsombor Egri Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+270995@code.launchpad.net

Commit message

Take custom key indexes into account in QSortFilterProxyModelQML::get().

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Fair point! Taken.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/plugin/sortfiltermodel.cpp'
2--- src/Ubuntu/Components/plugin/sortfiltermodel.cpp 2015-08-20 17:08:49 +0000
3+++ src/Ubuntu/Components/plugin/sortfiltermodel.cpp 2015-09-14 17:35:12 +0000
4@@ -220,8 +220,11 @@
5 {
6 QVariantMap res;
7 const QHash<int, QByteArray> roles = roleNames();
8- for(int role = 0; role < roles.count(); role++)
9- res.insert (roles[role], data(row, role));
10+ QHashIterator<int, QByteArray> i(roles);
11+ while (i.hasNext()) {
12+ i.next();
13+ res.insert(i.value(), data(row, i.key()));
14+ }
15 return res;
16 }
17

Subscribers

People subscribed via source and target branches