Merge lp:~osomon/ubuntu-phone-commons/appTemplate-packaging-fixes into lp:ubuntu-phone-commons
Status: | Merged |
---|---|
Approved by: | Michael Hall on 2013-04-08 |
Approved revision: | 21 |
Merged at revision: | 2 |
Proposed branch: | lp:~osomon/ubuntu-phone-commons/appTemplate-packaging-fixes |
Merge into: | lp:ubuntu-phone-commons |
Diff against target: |
148 lines (+31/-41) 8 files modified
.bzr-builddeb/default.conf (+2/-0) .bzrignore (+6/-0) debian/app-template.install (+4/-3) debian/compat (+1/-1) debian/control (+9/-10) debian/copyright (+5/-5) debian/rules (+3/-21) debian/source/format (+1/-1) |
To merge this branch: | bzr merge lp:~osomon/ubuntu-phone-commons/appTemplate-packaging-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Günter Schwann (community) | Approve on 2013-04-08 | ||
Ubuntu Core Apps Drivers | 2013-04-04 | Pending | |
Review via email:
|
Commit message
Packaging enhancements.
Description of the change
Each commit in this branch addresses a separate issue/improvement to the packaging, so it’s probably easier reviewed commit by commit.
Günter Schwann (schwann) wrote : | # |
Olivier Tilloy (osomon) wrote : | # |
> 57 + qtdeclarative5-
> ubuntu
> Should we still include the old "qt-components-
Not sure, so I kept it for now, I’ll check with the SDK team and update if needed.
> 58 + ${misc:Depends},
> I'd move that as the first dependency (all other packages I know do that)
You’re right. The package for webbrowser-app has it at the end, and it was moved there recently by someone more knowledgeable than me about packaging, so I assumed it was a well-known convention, but it turns out it’s not, so I’ll move it back to the beginning.
- 17. By Olivier Tilloy on 2013-04-05
-
Move back special dependencies to the beginning of the list, this seems to be a widely used convention.
- 18. By Olivier Tilloy on 2013-04-05
-
Remove the fallback dependency on the old UI toolkit package name, it is not needed any longer.
- 19. By Olivier Tilloy on 2013-04-05
-
Revert the last change, after all the fallback dependency is still needed for Quantal desktops.
any special reason for the files inside the debian dir have a different version??
77 Files: debian/*
78 Copyright: 2013 Canonical Ltd.
79 -License: LGPL-3.0
80 +License: LGPL-3
should we add the dir ".bzr-builddeb/" I am not sure what is that but we have that on the others projects.
Olivier Tilloy (osomon) wrote : | # |
> any special reason for the files inside the debian dir have a different
> version??
> 77 Files: debian/*
> 78 Copyright: 2013 Canonical Ltd.
> 79 -License: LGPL-3.0
> 80 +License: LGPL-3
Not that I know of, but that was already like this, so I left it alone.
Olivier Tilloy (osomon) wrote : | # |
> should we add the dir ".bzr-builddeb/" I am not sure what is that but we have
> that on the others projects.
This sets the split mode for the bzr builddeb plugin (see http://
It goes together with the change of debian/
This is specific to packages where we are upstream (i.e. developer == packager), and I think that core applications can be considered in this case.
- 20. By Olivier Tilloy on 2013-04-08
-
Set split mode for bzr builddeb plugin
(see http://jameswestby. net/bzr/ builddeb/ user_manual/ split.html). - 21. By Olivier Tilloy on 2013-04-08
-
Remove again the fallback dependency on qt-components-
ubuntu.
It is really not needed any longer, as the ubuntu-sdk-team release PPA contains the latest qtdeclarative5-ubuntu- ui-toolkit- plugin for quantal.
Olivier Tilloy (osomon) wrote : | # |
> > 57 + qtdeclarative5-
> > ubuntu
> > Should we still include the old "qt-components-
>
> Not sure, so I kept it for now, I’ll check with the SDK team and update if
> needed.
No, indeed, this is not needed any longer. I have removed it.
57 + qtdeclarative5- ubuntu- ui-toolkit- plugin | qt-components- ubuntu ubuntu" ?
Should we still include the old "qt-components-
58 + ${misc:Depends},
I'd move that as the first dependency (all other packages I know do that)