Merge lp:~osomon/ubuntu-calendar-app/reduce-newevent-popup-height into lp:ubuntu-calendar-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 95
Merged at revision: 94
Proposed branch: lp:~osomon/ubuntu-calendar-app/reduce-newevent-popup-height
Merge into: lp:ubuntu-calendar-app
Diff against target: 176 lines (+76/-32)
2 files modified
NewEvent.qml (+1/-2)
po/calendar-app.pot (+75/-30)
To merge this branch: bzr merge lp:~osomon/ubuntu-calendar-app/reduce-newevent-popup-height
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Günter Schwann (community) Approve
Ubuntu Calendar Developers Pending
Review via email: mp+183090@code.launchpad.net

Commit message

Reduce the height of the "new event" popup so that the OSK doesn’t partially hide the save button.

This is a temporary measure until we get a design decision on how to properly address the issue.

To post a comment you must log in.
Revision history for this message
Günter Schwann (schwann) wrote :

lgtm

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NewEvent.qml'
2--- NewEvent.qml 2013-08-20 14:32:27 +0000
3+++ NewEvent.qml 2013-08-30 08:28:30 +0000
4@@ -134,7 +134,7 @@
5 }
6 }
7
8- ListItem.Header { text: i18n.tr("Location") }
9+ ListItem.Header { text: i18n.tr("Location & People") }
10 ListItem.Empty {
11 highlightWhenPressed: false
12 TextField {
13@@ -148,7 +148,6 @@
14 }
15 }
16
17- ListItem.Header { text: i18n.tr("People") }
18 ListItem.Empty {
19 highlightWhenPressed: false
20 TextField {
21
22=== modified file 'po/calendar-app.pot'
23--- po/calendar-app.pot 2013-06-12 18:18:46 +0000
24+++ po/calendar-app.pot 2013-08-30 08:28:30 +0000
25@@ -1,5 +1,5 @@
26 # SOME DESCRIPTIVE TITLE.
27-# Copyright (C) YEAR Canonical Ltd.
28+# Copyright (C) YEAR Canonical Ltd.
29 # This file is distributed under the same license as the PACKAGE package.
30 # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
31 #
32@@ -8,7 +8,7 @@
33 msgstr ""
34 "Project-Id-Version: calendar-app\n"
35 "Report-Msgid-Bugs-To: \n"
36-"POT-Creation-Date: 2013-06-12 17:24+0200\n"
37+"POT-Creation-Date: 2013-08-30 10:23+0200\n"
38 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
39 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
40 "Language-Team: LANGUAGE <LL@li.org>\n"
41@@ -17,7 +17,14 @@
42 "Content-Type: text/plain; charset=CHARSET\n"
43 "Content-Transfer-Encoding: 8bit\n"
44
45-#: ../DiaryView.qml:54
46+#. TRANSLATORS: this is a time formatting string,
47+#. see http://qt-project.org/doc/qt-5.0/qtqml/qml-qtquick2-date.html#details for valid expressions
48+#: ../DayView.qml:29 ../TimeLineBackground.qml:22 ../TimeLineView.qml:103
49+#: ../WeekView.qml:27
50+msgid "HH"
51+msgstr ""
52+
53+#: ../DiaryView.qml:43
54 msgid "(+) New Event"
55 msgstr ""
56
57@@ -29,54 +36,92 @@
58 msgid "Edit"
59 msgstr ""
60
61-#: ../EventDetails.qml:150 ../NewEvent.qml:112
62+#: ../EventDetails.qml:150
63 msgid "People"
64 msgstr ""
65
66-#: ../NewEvent.qml:20
67+#: ../NewEvent.qml:23
68 msgid "Create event"
69 msgstr ""
70
71-#: ../NewEvent.qml:25
72+#: ../NewEvent.qml:29
73 msgid "Add event name"
74 msgstr ""
75
76-#: ../NewEvent.qml:99
77-msgid "Location"
78-msgstr ""
79-
80-#: ../NewEvent.qml:104
81+#: ../NewEvent.qml:102
82+msgid "to"
83+msgstr ""
84+
85+#: ../NewEvent.qml:137
86+msgid "Location & People"
87+msgstr ""
88+
89+#: ../NewEvent.qml:143
90 msgid "Add Location"
91 msgstr ""
92
93-#: ../NewEvent.qml:117
94+#: ../NewEvent.qml:156
95 msgid "Invite People"
96 msgstr ""
97
98-#: ../NewEvent.qml:128
99+#: ../NewEvent.qml:168
100+msgid "Error"
101+msgstr ""
102+
103+#: ../NewEvent.qml:171
104+msgid "Ok"
105+msgstr ""
106+
107+#: ../NewEvent.qml:177
108 msgid "Save"
109 msgstr ""
110
111-#. TRANSLATORS: this is a time formatting string,
112-#. see http://qt-project.org/doc/qt-5.0/qtqml/qml-qtquick2-date.html#details for valid expressions
113-#: ../TimeLineView.qml:147
114-msgid "HH:mm"
115-msgstr ""
116-
117-#: ../calendar.qml:31
118-msgid "To-do"
119-msgstr ""
120-
121-#: ../calendar.qml:36
122+#: ../NewEvent.qml:205
123+msgid "End time can't be before start time"
124+msgstr ""
125+
126+#: ../TimePicker.qml:23
127+msgid "Time"
128+msgstr ""
129+
130+#: ../TimePicker.qml:49
131+msgid "Hour"
132+msgstr ""
133+
134+#: ../TimePicker.qml:63
135+msgid "Minute"
136+msgstr ""
137+
138+#: ../TimePicker.qml:73
139+msgid "Cancel"
140+msgstr ""
141+
142+#: ../TimePicker.qml:82
143+msgid "OK"
144+msgstr ""
145+
146+#: ../calendar.qml:52
147 msgid "New Event"
148 msgstr ""
149
150-#: ../calendar.qml:41 ../calendar.qml:48
151-msgid "Timeline"
152-msgstr ""
153-
154-#: ../calendar.qml:45
155-msgid "Diary"
156+#: ../calendar.qml:60
157+msgid "Today"
158+msgstr ""
159+
160+#: ../calendar.qml:72
161+msgid "Year"
162+msgstr ""
163+
164+#: ../calendar.qml:93
165+msgid "Month"
166+msgstr ""
167+
168+#: ../calendar.qml:116
169+msgid "Week"
170+msgstr ""
171+
172+#: ../calendar.qml:132
173+msgid "Day"
174 msgstr ""
175
176 #: ../.build/calendar-app.desktop.js:1

Subscribers

People subscribed via source and target branches

to status/vote changes: