Merge ~osomon/ubuntu-app-platform:add-locales-all into ubuntu-app-platform:master

Proposed by Olivier Tilloy
Status: Merged
Approved by: Christian Dywan
Approved revision: 8676bf0ce8fc24317aa71bd0d2f9710eb17e8bcf
Merged at revision: 94ecd86d28e7b116d44db13150be0178afb85d6c
Proposed branch: ~osomon/ubuntu-app-platform:add-locales-all
Merge into: ubuntu-app-platform:master
Diff against target: 13 lines (+2/-0)
1 file modified
snapcraft.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Christian Dywan Approve
Review via email: mp+311947@code.launchpad.net

Commit message

Add locales-all to the stage packages to work around LP: #1576282.

To post a comment you must log in.
Revision history for this message
Christian Dywan (kalikiana) wrote :

This weighs in at 127M! I feel we need to have the discussion about language packs at this point, because effectively all the individual platform snaps would need that. Imagine having Qt, Qt 5.7, KDE and GTK+ with each of them containing this snap. That would defeat the point of saving space.

review: Needs Fixing
Revision history for this message
Olivier Tilloy (osomon) wrote :

I agree. Note that this is only a (hopefully) temporary workaround to bug #1576282. This is not really about language packs, it’s about the lack of support for locales definitions in the core image. So really, this is a bug that needs to be fixed in snapd.

Revision history for this message
Christian Dywan (kalikiana) wrote :

Let's get this in as per the verdict of the discussion: the increase in size is negligible and so is the benefit of a separate language pack for that reason.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 534fe16..587f3a6 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -69,6 +69,8 @@ parts:
6 - libxrender1
7 - perl
8 - zlib1g
9+ # workaround for LP: #1576282
10+ - locales-all
11 # qtmultimedia
12 - libpulse0
13 # ubuntu-sdk-libs

Subscribers

People subscribed via source and target branches