Merge ~osomon/ubiquity:impish-release-notes-hyperlink-1945015 into ubiquity:master

[Olivier Tilloy]

Use xdg-open instead of sensible-browser to open the release notes and other hyperlinks consistently (LP: #1945015).

[Dimitri John Ledkov (xnox)]

review: Approve

[Dimitri John Ledkov (xnox)]

If any flavours fail to work with xdg-open, they must be fixed as supporting xdg-open is a must for many years now.

[Sebastien Bacher (seb128)]

Sounds sensible to me but I'm not part of the ubiquity team to change the status

review: Approve

diff --git a/debian/changelog b/debian/changelog
index 41af5b7..9dbcf4d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+ubiquity (21.10.6) UNRELEASED; urgency=medium
+
+  * ubiquity/frontend/gtk_ui.py, ubiquity/misc.py, debian/control: use
+    xdg-open instead of sensible-browser to open the release notes and
+    other hyperlinks consistently (LP: #1945015)
+
+ -- Olivier Tilloy <[e-mail]>  Mon, 27 Sep 2021 15:14:25 +0200
+
 ubiquity (21.10.5) impish; urgency=medium
 
   * tests/test_gtkwidgets.py, ubiquity/frontend/gtk_ui.py:
diff --git a/debian/control b/debian/control
index 273c97f..70a46d8 100644
--- a/debian/control
+++ b/debian/control
@@ -99,6 +99,7 @@ Depends: adduser,
          ubiquity-casper,
          ubiquity-frontend-${mangled-version},
          wget,
+         xdg-utils,
          dctrl-tools,
          ${console-setup-depends},
          ${misc:Depends},
@@ -144,7 +145,6 @@ Depends: busybox-static | busybox,
          python3-dbus,
          python3-gi,
          python3-gi-cairo,
-         sensible-utils,
          ubiquity (= ${binary:Version}),
          ${misc:Depends},
          ${python3:Depends},
diff --git a/ubiquity/frontend/gtk_ui.py b/ubiquity/frontend/gtk_ui.py
index e78ef33..77e0cde 100644
--- a/ubiquity/frontend/gtk_ui.py
+++ b/ubiquity/frontend/gtk_ui.py
@@ -964,9 +964,7 @@ class Wizard(BaseFrontend):
             request = decision.get_request()
             uri = request.get_uri()
             decision.ignore()
-            subprocess.Popen(['sensible-browser', uri],
-                             close_fds=True,
-                             preexec_fn=misc.drop_all_privileges)
+            misc.launch_uri(uri)
             return True
         return False
 
diff --git a/ubiquity/misc.py b/ubiquity/misc.py
index 86dbdbd..bc88d5d 100644
--- a/ubiquity/misc.py
+++ b/ubiquity/misc.py
@@ -962,7 +962,7 @@ min_install_size = None
 
 
 def launch_uri(uri):
-    subprocess.Popen(['sensible-browser', uri], close_fds=True,
+    subprocess.Popen(['xdg-open', uri], close_fds=True,
                      preexec_fn=drop_all_privileges)