Merge lp:~osomon/oxide/tolerant-GURL2QUrl into lp:~oxide-developers/oxide/oxide.trunk
Proposed by
Olivier Tilloy
Status: | Rejected |
---|---|
Rejected by: | Olivier Tilloy |
Proposed branch: | lp:~osomon/oxide/tolerant-GURL2QUrl |
Merge into: | lp:~oxide-developers/oxide/oxide.trunk |
Diff against target: |
44 lines (+25/-1) 1 file modified
qt/core/browser/oxide_qt_browser_platform_integration.cc (+25/-1) |
To merge this branch: | bzr merge lp:~osomon/oxide/tolerant-GURL2QUrl |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy (community) | Disapprove | ||
Chris Coulson | Pending | ||
Review via email: mp+257331@code.launchpad.net |
Commit message
Be more tolerant when converting a GURL to a QUrl when calling QDesktopService
Description of the change
Note: I’m not sure whether this tolerant GURL2QUrl function should be used everywhere we translate a GURL into a QUrl (quite a few places in the codebase), or if it’s ok to keep it confined there.
To post a comment you must log in.
Unmerged revisions
- 1057. By Olivier Tilloy
-
Add a debug check.
- 1056. By Olivier Tilloy
-
Be more tolerant when converting a GURL to a QUrl when calling QDesktopService
s::openUrl( ).
Not needed any longer as bug #1447617 is invalid now.