Merge lp:~osomon/oxide/reset-touch-selection-state-when-navigating into lp:~oxide-developers/oxide/oxide.trunk

Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 1372
Proposed branch: lp:~osomon/oxide/reset-touch-selection-state-when-navigating
Merge into: lp:~oxide-developers/oxide/oxide.trunk
Diff against target: 47 lines (+9/-0)
1 file modified
shared/browser/oxide_web_contents_view.cc (+9/-0)
To merge this branch: bzr merge lp:~osomon/oxide/reset-touch-selection-state-when-navigating
Reviewer Review Type Date Requested Status
Chris Coulson Approve
Review via email: mp+287978@code.launchpad.net

Commit message

Reset the touch selection state when navigating to a different page.

To post a comment you must log in.
1369. By Olivier Tilloy

Call TouchSelectionChanged() in a number of places instead of in DidNavigateMainFrame().

Revision history for this message
Chris Coulson (chrisccoulson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shared/browser/oxide_web_contents_view.cc'
2--- shared/browser/oxide_web_contents_view.cc 2016-03-01 18:44:48 +0000
3+++ shared/browser/oxide_web_contents_view.cc 2016-03-10 17:24:23 +0000
4@@ -391,6 +391,7 @@
5 }
6
7 EditingCapabilitiesChanged();
8+ TouchSelectionChanged();
9 }
10
11 void WebContentsView::DidNavigateMainFrame(
12@@ -416,6 +417,8 @@
13 static_cast<RenderWidgetHostView*>(rwh->GetView())->SetContainer(this);
14
15 web_contents()->GetRenderWidgetHostView()->Hide();
16+
17+ TouchSelectionChanged();
18 }
19
20 void WebContentsView::DidDestroyFullscreenWidget(int routing_id) {
21@@ -441,6 +444,8 @@
22 } else {
23 orig_rwhv->Blur();
24 }
25+
26+ TouchSelectionChanged();
27 }
28
29 void WebContentsView::DidAttachInterstitialPage() {
30@@ -450,6 +455,8 @@
31 RenderWidgetHostView* rwhv = GetRenderWidgetHostView();
32 rwhv->SetContainer(this);
33 interstitial_rwh_id_ = rwhv->GetRenderWidgetHost();
34+
35+ TouchSelectionChanged();
36 }
37
38 void WebContentsView::DidDetachInterstitialPage() {
39@@ -464,6 +471,8 @@
40 }
41
42 static_cast<RenderWidgetHostView*>(rwh->GetView())->SetContainer(nullptr);
43+
44+ TouchSelectionChanged();
45 }
46
47 void WebContentsView::CompositorSwapFrame(CompositorFrameHandle* handle) {

Subscribers

People subscribed via source and target branches