lp:~osomon/oxide/renderProcessGone

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~oxide-developers/oxide/oxide.trunk at revision 1064

Chris Coulson: Approve on 2015-05-11

Diff: 393 lines (+173/-2)

12 files modified

qt/core/browser/oxide_qt_web_view.cc (+21/-0)
qt/core/browser/oxide_qt_web_view.h (+4/-0)
qt/core/glue/oxide_qt_web_view_proxy.h (+8/-0)
qt/core/glue/oxide_qt_web_view_proxy_client.h (+2/-0)
qt/qmlplugin/oxide_qml_plugin.cc (+2/-0)
qt/quick/api/oxideqquickwebview.cc (+22/-0)
qt/quick/api/oxideqquickwebview_p.h (+12/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+1/-0)
qt/tests/qmltests/api/tst_WebView_webProcessStatus.qml (+40/-0)
qt/tests/qmltests/oxide_qml_testing_plugin.cc (+49/-1)
shared/browser/oxide_web_view.cc (+9/-1)
shared/browser/oxide_web_view.h (+3/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1375272: Add an API to signal the application that the renderer process crashed

High

Fix Released

Link a bug report

Related blueprints

1065. By Olivier Tilloy on 2015-05-11

Skip the tests for now until bug #1452407 is fixed.

1064. By Olivier Tilloy on 2015-05-11

Unify OnRenderViewReady() and OnRenderProcessGone() into one single method, as they serve the exact same purpose.

1063. By Olivier Tilloy on 2015-05-11

Return WEB_PROCESS_RUNNING for the web process status when it hasn’t started yet, for consistency with how WebContents initializes crashed_status_.

1062. By Olivier Tilloy on 2015-05-06

Add unit tests for WebView.webProcessStatus.

1061. By Olivier Tilloy on 2015-05-06

Replace the renderProcessGone signal with a webProcessStatus property on the webview.

1060. By Olivier Tilloy on 2015-04-29

One more sanity check.

1059. By Olivier Tilloy on 2015-04-29

Add build-time assertions to ensure that casting a base::TerminationStatus to an int is safe and will always result in a correct value on the other side.

1058. By Olivier Tilloy on 2015-04-29

Safety checks before doing a static cast.

1057. By Olivier Tilloy on 2015-04-28

Add a WebView::renderProcessGone(status) signal to notify embedders when the renderer process crashed or was killed.

1056. By Chris Coulson on 2015-04-28

Fix a memory corruption when the visibilty of a webview is changed