Merge lp:~osomon/oxide/ignore-invalid-SelectionChanged into lp:~oxide-developers/oxide/oxide.trunk

[Olivier Tilloy]

Ignore SelectionChanged() notification when the selection is invalid.

[lp:~osomon/oxide/ignore-invalid-SelectionChanged]

789. By Olivier Tilloy on 2014-10-13

Add a reference to an upstream bug report.

[Chris Coulson (chrisccoulson)]

review: Approve

=== modified file 'shared/browser/oxide_render_widget_host_view.cc'
--- shared/browser/oxide_render_widget_host_view.cc	2014-10-10 20:29:46 +0000
+++ shared/browser/oxide_render_widget_host_view.cc	2014-10-13 11:05:27 +0000
@@ -55,6 +55,17 @@
 void RenderWidgetHostView::SelectionChanged(const base::string16& text,
                                             size_t offset,
                                             const gfx::Range& range) {
+  if ((range.GetMin() - offset) > text.length()) {
+    // Got an invalid selection (see https://launchpad.net/bugs/1375900).
+    // The issue lies in content::RenderFrameImpl::SyncSelectionIfRequired(…)
+    // where the selection text and the corresponding range are computed
+    // separately. If the word that just got committed is at the beginning of a
+    // new line, the selection range includes the trailing newline character(s)
+    // whereas the selection text truncates them.
+    // This looks very similar to https://crbug.com/101435.
+    return;
+  }
+
   content::RenderWidgetHostViewBase::SelectionChanged(text, offset, range);
 
   if (delegate_) {