Merge ~osomon/oxide:fix-zoomfactor-unit-tests into oxide:master

Proposed by Olivier Tilloy
Status: Merged
Approved by: Chris Coulson
Approved revision: 37c375107120452de8a912b41bf7d9dd284872f7
Merged at revision: bfea1eefd0edb9e0b58550831f4b9e117a255c3d
Proposed branch: ~osomon/oxide:fix-zoomfactor-unit-tests
Merge into: oxide:master
Diff against target: 25 lines (+8/-2)
1 file modified
qt/tests/qmltests/api/tst_WebView_zoomFactor.qml (+8/-2)
Reviewer Review Type Date Requested Status
Oxide Developers Pending
Review via email: mp+322627@code.launchpad.net

Commit message

Make zoom factor unit tests more robust.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/qt/tests/qmltests/api/tst_WebView_zoomFactor.qml b/qt/tests/qmltests/api/tst_WebView_zoomFactor.qml
2index d4479df..3126331 100644
3--- a/qt/tests/qmltests/api/tst_WebView_zoomFactor.qml
4+++ b/qt/tests/qmltests/api/tst_WebView_zoomFactor.qml
5@@ -32,12 +32,18 @@ TestWebView {
6
7 function verify_zoomFactor(factor) {
8 compare(webView.zoomFactor, factor);
9+ function testpixel(i, color) {
10+ var image = grabImage(webView);
11+ return (image.pixel(i, i) == color);
12+ }
13+ var zoomedSize = Math.round(originalSize * factor);
14+ verify(TestUtils.waitFor(function() { return testpixel(zoomedSize - 1, red); }));
15+ verify(TestUtils.waitFor(function() { return testpixel(zoomedSize, white); }));
16 var image = grabImage(webView);
17- var zoomedSize = originalSize * factor;
18 for (var i = 0; i < zoomedSize; ++i) {
19 compare(image.pixel(i, i), red);
20 }
21- compare(image.pixel(zoomedSize + 1, zoomedSize + 1), white);
22+ compare(image.pixel(zoomedSize, zoomedSize), white);
23 }
24
25 function test_WebView_zoomFactor() {

Subscribers

People subscribed via source and target branches