Merge lp:~osomon/notes-app/wait-toolbar-autohide into lp:notes-app

Proposed by Olivier Tilloy
Status: Needs review
Proposed branch: lp:~osomon/notes-app/wait-toolbar-autohide
Merge into: lp:notes-app
Diff against target: 15 lines (+4/-1)
1 file modified
tests/autopilot/notes_app/tests/ (+4/-1)
To merge this branch: bzr merge lp:~osomon/notes-app/wait-toolbar-autohide
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email:

Commit message

Wait for the toolbar to autohide instead of proactively closing it at startup.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

After installing notes-app and notes-app-autopilot from this branch, I ran the notes_app test 7 times on a Nexus 4. Every time the result was a success with 0 failures.

Unmerged revisions

245. By Olivier Tilloy on 2014-01-21

Wait for the toolbar to autohide instead of proactively closing it at startup.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/notes_app/tests/'
2--- tests/autopilot/notes_app/tests/ 2013-12-11 17:29:27 +0000
3+++ tests/autopilot/notes_app/tests/ 2014-01-21 10:40:46 +0000
4@@ -48,7 +48,10 @@
5 super(NotesAppTestCase, self).setUp()
6 self.launch_app()
7 self.main_window.visible.wait_for(True)
8- self.main_window.close_toolbar()
9+ # Wait for the toolbar to auto-hide
10+ toolbar = self.main_window.get_toolbar()
11+ toolbar.opened.wait_for(False)
12+ toolbar.animating.wait_for(False)
14 """Workaround to find the qmlscene binary via shell globbing.
15 This is needed since we can't rely on qt5-default being installed on


People subscribed via source and target branches