notes-app

Merge lp:~osomon/notes-app/remove-useless-lambdas into lp:notes-app

  1. remove-useless-lambdas
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 187
Merged at revision: 188
Proposed branch: lp:~osomon/notes-app/remove-useless-lambdas
Merge into: lp:notes-app
Diff against target: 21 lines (+2/-2)
1 file modified
tests/autopilot/notes_app/tests/test_create.py (+2/-2)
To merge this branch: bzr merge lp:~osomon/notes-app/remove-useless-lambdas
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Günter Schwann (community) Approve
Review via email: mp+188070@code.launchpad.net

Commit message

Remove a couple of lambda calls, useless because the assertion is on a property.

To post a comment you must log in.
Revision history for this message
Günter Schwann (schwann) wrote :

ok

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:187
http://jenkins.qa.ubuntu.com/job/notes-app-ci/152/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4120/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1754
    FAILURE: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/47/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/50
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/50/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/47
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4237/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1756
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1756/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1464
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1476

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/152/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/notes-app-autolanding/68/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4121
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1757
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-autolanding/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-autolanding/34
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-autolanding/34/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-autolanding/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/421
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4240
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4240/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1759
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1759/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1465
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1477

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:187
http://jenkins.qa.ubuntu.com/job/notes-app-ci/153/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4196
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1864/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/48
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/51
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/51/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/48
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/492
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/64
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/64/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1866
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1866/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1562
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1574/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/153/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/notes_app/tests/test_create.py'
2--- tests/autopilot/notes_app/tests/test_create.py 2013-07-29 20:53:21 +0000
3+++ tests/autopilot/notes_app/tests/test_create.py 2013-09-27 14:43:00 +0000
4@@ -101,7 +101,7 @@
5 note_y + content_h + ((note_h - content_h) / 2))
6 self.pointing_device.click()
7
8- self.assertThat(lambda: content.activeFocus, Eventually(Equals(True)))
9+ self.assertThat(content.activeFocus, Eventually(Equals(True)))
10
11 def test_note_focus_on_second_click_inside(self):
12 notes = self.main_window.get_notes()
13@@ -125,7 +125,7 @@
14 content_x + content_w / 2, content_y + content_h / 2)
15 self.pointing_device.click()
16
17- self.assertThat(lambda: content.activeFocus, Eventually(Equals(True)))
18+ self.assertThat(content.activeFocus, Eventually(Equals(True)))
19
20 def test_note_unfocused_when_collapsed(self):
21 header = self.main_window.get_header()

Subscribers

People subscribed via source and target branches