Code review comment for lp:~osomon/moovida/player_feedback

Revision history for this message
Olivier Tilloy (osomon) wrote :

This bundle fixes various bugs in the player OSD:

1) The OSD wasn't really cleared when necessary, despite various attempts to fix that (see https://bugs.launchpad.net/moovida/+bug/432269 among others). The issue was less easy to observe but it was there (hint: a slow network connection helps to reproduce the issue).

2) The default thumbnail for music was that of videos (https://bugs.launchpad.net/moovida/+bug/463733).

3) The posters for TV episodes were never shown in the OSD, despite the fact that we had their URIs in the DB (https://bugs.launchpad.net/moovida/+bug/485933).

With all that the OSD is hopefully less buggy and a tad more useful.

Thanks for the review!

« Back to merge proposal