Code review comment for lp:~osomon/moovida/fix_uri_quoting
Revision history for this message
| Guillaume Emont (guijemont) wrote | # |
review:
Approve
(code functional)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
worksforme(tm), and I'm ok with the changes.
Did test on ubuntu hardy and vista. I didn't test with chinese characters, but considering the changes, if there is no regression with the # character, there shouldn't be any regression with chinese characters either.
I guess the comment could be shorter (ideally), but I have nothing better to propose, so I'm OK with that.