Code review comment for lp:~osomon/moovida/fix_player_exit

Revision history for this message
Olivier Tilloy (osomon) wrote :

This branch contains changes to fix a functional regression introduced by

One of the symptoms of the regression was bug #488291. The patch that was committed with revision 1603 was in fact a mere workaround.

Another symptom was described by Peter on the developers' mailing list. See

And there were potentially other undesirable side-effects.

The changes make the player exit only when the media cannot even be partly played, not every time the status of the player goes to STOPPED (which also happens when transitioning between media in a playlist).

Thanks for the review.

« Back to merge proposal