Merge lp:~osomon/moovida/fix_player_exit into lp:moovida

Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 1604
Proposed branch: lp:~osomon/moovida/fix_player_exit
Merge into: lp:moovida
Diff against target: 33 lines (+4/-1)
2 files modified
elisa-plugins/elisa/plugins/poblesec/ (+3/-0)
elisa-plugins/elisa/plugins/poblesec/ (+1/-1)
To merge this branch: bzr merge lp:~osomon/moovida/fix_player_exit
Reviewer Review Type Date Requested Status
Florian Boucault (community) code functional Approve
Fernando Casanova partial-functional code Approve
Review via email:
To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

This branch contains changes to fix a functional regression introduced by

One of the symptoms of the regression was bug #488291. The patch that was committed with revision 1603 was in fact a mere workaround.

Another symptom was described by Peter on the developers' mailing list. See

And there were potentially other undesirable side-effects.

The changes make the player exit only when the media cannot even be partly played, not every time the status of the player goes to STOPPED (which also happens when transitioning between media in a playlist).

Thanks for the review.

Revision history for this message
Olivier Tilloy (osomon) wrote :

I reported bug #489177 to track the issue.

Revision history for this message
Fernando Casanova (fcasanova) wrote :


the patch fixes the problem with the tvseries playlist. Now after playing 1 tvepisode, the player stays on top and the playback continues.

review: Approve (partial-functional code)
Revision history for this message
Florian Boucault (fboucault) wrote :

Thank you!

review: Approve (code functional)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'elisa-plugins/elisa/plugins/poblesec/'
--- elisa-plugins/elisa/plugins/poblesec/ 2009-11-23 09:42:27 +0000
+++ elisa-plugins/elisa/plugins/poblesec/ 2009-11-27 12:35:26 +0000
@@ -57,6 +57,9 @@
57 else:57 else:
58 subtitle = _("Unfortunately Moovida cannot play the selected " \58 subtitle = _("Unfortunately Moovida cannot play the selected " \
59 "media.")59 "media.")
60 if sender is main_controller.current_player:
61 # Cannot even partly play the media, exit the player
62 sender.exit()
61 if exception.missing_decoders:64 if exception.missing_decoders:
62 details = _("Installing the following codecs should allow " \65 details = _("Installing the following codecs should allow " \
=== modified file 'elisa-plugins/elisa/plugins/poblesec/'
--- elisa-plugins/elisa/plugins/poblesec/ 2009-11-23 09:55:40 +0000
+++ elisa-plugins/elisa/plugins/poblesec/ 2009-11-27 12:35:26 +0000
@@ -1175,6 +1175,7 @@
1175 def exit(self):1175 def exit(self):
1176 """1176 """
1177 Exit the player by asking poblesec's main controller to hide it.1177 Exit the player by asking poblesec's main controller to hide it.
1178 It is assumed that the player is the currently visible one.
1178 """1179 """
1179 controllers = self.frontend.retrieve_controllers('/poblesec')1180 controllers = self.frontend.retrieve_controllers('/poblesec')
1180 main = controllers[0]1181 main = controllers[0]
@@ -1396,7 +1397,6 @@
1396 self.show_on_screen_display()1397 self.show_on_screen_display()
1397 elif status == player.STOPPED:1398 elif status == player.STOPPED:
1398 self.background.clear()1399 self.background.clear()
1399 self.exit()
1400 return True1400 return True
1402 def _stop_monitoring(self, *args):1402 def _stop_monitoring(self, *args):


People subscribed via source and target branches