Merge lp:~osomon/moovida/fix_player_exit into lp:moovida
Proposed by
Olivier Tilloy
Status: | Merged |
---|---|
Merged at revision: | 1604 |
Proposed branch: | lp:~osomon/moovida/fix_player_exit |
Merge into: | lp:moovida |
Diff against target: |
33 lines (+4/-1) 2 files modified
elisa-plugins/elisa/plugins/poblesec/errors_handling.py (+3/-0) elisa-plugins/elisa/plugins/poblesec/player_video.py (+1/-1) |
To merge this branch: | bzr merge lp:~osomon/moovida/fix_player_exit |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Florian Boucault (community) | code functional | Approve | |
Fernando Casanova | partial-functional code | Approve | |
Review via email: mp+15313@code.launchpad.net |
To post a comment you must log in.
This branch contains changes to fix a functional regression introduced by http:// bazaar. launchpad. net/~elisa- developers/ moovida/ relook/ revision/ 1601.
One of the symptoms of the regression was bug #488291. The patch that was committed with revision 1603 was in fact a mere workaround.
Another symptom was described by Peter on the developers' mailing list. See http:// lists.moovida. com/pipermail/ developers- list/2009- November/ 001748. html.
And there were potentially other undesirable side-effects.
The changes make the player exit only when the media cannot even be partly played, not every time the status of the player goes to STOPPED (which also happens when transitioning between media in a playlist).
Thanks for the review.