Code review comment for lp:~osomon/moovida/element_redirections

Revision history for this message
Olivier Tilloy (osomon) wrote :

This branch fixes wrong handling of stream redirections in the general case where the "new-location" attribute of the message contains a full URI rather than just a filename.

Both cases are now handled gracefully, although it's unclear whether the latter is valid (it can be observed for Apple trailers so we need to support it anyway).

As a side effect, the fix improves the situation regarding bug #494713: for some mms:// streams Moovida previously crashed after entering an infinite loop of redirections, it now fails gracefully (reporting an error message to the user). It can be verified with e.g. mms://

I also fixed this annoying issue that the Player was not logging anything.

« Back to merge proposal