gallery-app

Merge lp:~osomon/gallery-app/wait-for-confirm-dialogue into lp:gallery-app

  1. wait-for-confirm-dialogue
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 891
Merged at revision: 892
Proposed branch: lp:~osomon/gallery-app/wait-for-confirm-dialogue
Merge into: lp:gallery-app
Diff against target: 28 lines (+3/-1)
1 file modified
tests/autopilot/gallery_app/tests/test_photo_viewer.py (+3/-1)
To merge this branch: bzr merge lp:~osomon/gallery-app/wait-for-confirm-dialogue
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+199076@code.launchpad.net

Commit message

Fix a flaky test by always waiting for the confirmation dialogue to be fully visible before interacting with it.

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

For reference, this is an occurrence of such a failure: http://ci.ubuntu.com/smokeng/trusty/touch/mako/68:20131216:20131211.2/5483/gallery-app-autopilot/575353/

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:891
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/606/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-ci/31/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/31/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-ci/31/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1726/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1650/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1726/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1650/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/606/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:891
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/610/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-ci/35/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/35/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-ci/35/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1744/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1668/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1744/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1668/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/610/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:891
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/612/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/37
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/37/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1771
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1691
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1564
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1771
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1771/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1691
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1691/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4194
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2417

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/612/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/gallery-app-autolanding/262/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-autolanding/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-autolanding/11
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-autolanding/11/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-autolanding/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1788
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1707/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1579
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1788
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1788/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1707
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1707/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4208/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2436

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/gallery-app-autolanding/263/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-autolanding/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-autolanding/12
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-autolanding/12/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-autolanding/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1794
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1713/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1583
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1794
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1794/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1713
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1713/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4211/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2440

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/gallery_app/tests/test_photo_viewer.py'
2--- tests/autopilot/gallery_app/tests/test_photo_viewer.py 2013-11-04 03:27:55 +0000
3+++ tests/autopilot/gallery_app/tests/test_photo_viewer.py 2013-12-16 07:50:49 +0000
4@@ -79,7 +79,7 @@
5 def test_photo_delete_works(self):
6 """Clicking the trash button must show the delete dialog."""
7 self.main_view.open_toolbar().click_button("deleteButton")
8- delete_dialog = self.get_delete_dialog()
9+ self.get_delete_dialog()
10
11 photo_viewer = self.photo_viewer.get_main_photo_viewer()
12
13@@ -91,6 +91,7 @@
14 Eventually(Equals(True)))
15
16 self.main_view.open_toolbar().click_button("deleteButton")
17+ self.get_delete_dialog()
18
19 delete_item = self.photo_viewer.get_delete_popover_delete_item()
20 self.click_item(delete_item)
21@@ -100,6 +101,7 @@
22 Eventually(Equals(False)))
23
24 self.main_view.open_toolbar().click_button("deleteButton")
25+ self.get_delete_dialog()
26
27 delete_item = self.photo_viewer.get_delete_popover_delete_item()
28 self.click_item(delete_item)

Subscribers

People subscribed via source and target branches